Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing entries from demozoo #258

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

dag7dev
Copy link
Contributor

@dag7dev dag7dev commented Dec 18, 2024

What's been included:

  • old roms that didn't scraped very well
  • newer roms: since the script creation in 2021, newer productions have been added

The usual saulin is missing (it has been already removed in the past).

Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some referenced screenshots cannot be found? Could you try running the tests locally to see what breaks @dag7dev ?

"veitikka-ja-visionaari.png"
],
"slug": "veitikka-ja-visionaari",
"title": "Veitikka ja vision\u00e4\u00e4ri",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have encoding issues here..

@avivace
Copy link
Member

avivace commented Dec 18, 2024

@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy)

@dag7dev
Copy link
Contributor Author

dag7dev commented Dec 18, 2024

I believe we have encoding issues here..

is it an issue? they are these characters: ää

@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy)

isnt better yyyy-mm-dd ?

@avivace
Copy link
Member

avivace commented Dec 18, 2024

I believe we have encoding issues here..

is it an issue? they are these characters: ää

@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy)

isnt better yyyy-mm-dd ?

sorry yes that's the date that gets set. What I meant was that this happen when the full information is available (day, month year) in the "released" line in demozoo, but not when this is partial (e.g. "2009" or "august 2009" cases are not handled yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants