-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing entries from demozoo #258
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some referenced screenshots cannot be found? Could you try running the tests locally to see what breaks @dag7dev ?
"veitikka-ja-visionaari.png" | ||
], | ||
"slug": "veitikka-ja-visionaari", | ||
"title": "Veitikka ja vision\u00e4\u00e4ri", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have encoding issues here..
@dag7dev I've also updated the scraper to retain the original demozoo link and parse the release date (when it's complete (dd-mm-yyyy) |
is it an issue? they are these characters: ää
isnt better yyyy-mm-dd ? |
sorry yes that's the date that gets set. What I meant was that this happen when the full information is available (day, month year) in the "released" line in demozoo, but not when this is partial (e.g. "2009" or "august 2009" cases are not handled yet) |
What's been included:
The usual saulin is missing (it has been already removed in the past).