Default manager export #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a default storage manager to main export, as well as a config() method for the StorageManager class in order to reconfigure the default storage manager without reinstantiating. This allows callers to do storage manager setup once at application start and reuse the same instances without needing to require() a separate file where a configured StorageManager has been set up. This is a similar pattern to how popular database and logging libraries export default containers for connections or loggers. Seeing as storage drivers fall under a similar class of reusability throughout an application, use of this pattern seems appropriate in this library.
Note: I submitted this to slynova-org as well, but that repo doesn't seem to be particularly active, and seeing as you've put all this work into actually making some active improvements I figured I'd just try here instead of publishing yet another version of this library.
Additional note: I did some incredibly minor cleanup both for eslint as well as for the actual build (needed to add 'dom' to the lib in tsconfig), don't know if this is something that has changed in the last two months or what.. regardless its just a type checking thing, don't think it actually impacts any of the output.