feat: English on Mobile #1303
Merged
feat: English on Mobile #1303
+931
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirajn2311
reviewed
Dec 15, 2024
Nirajn2311
reviewed
Dec 15, 2024
Nirajn2311
reviewed
Dec 15, 2024
mobile-app/lib/ui/views/learn/challenge/templates/multiple_choice/multiple_choice_view.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/ui/views/learn/challenge/challenge_viewmodel.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/ui/views/learn/challenge/templates/english/english_view.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/ui/views/learn/challenge/templates/english/english_view.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/ui/views/learn/challenge/templates/english/english_view.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/ui/views/learn/challenge/templates/english/english_view.dart
Outdated
Show resolved
Hide resolved
mobile-app/lib/ui/views/learn/challenge/templates/english/english_view.dart
Outdated
Show resolved
Hide resolved
I don't know what to do about this. It seems to be an HTML issue. |
This is a temporary fix
Ok found the cause of the bug. When the view loads up initially, the audio is still loading and the spinner takes up more height than the progress bar so when the progress bar appears the whole UI gets a sudden shift up. But for some reason the text don't move up. For now I've put in a temporary fix |
Nirajn2311
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #XXXXX