Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pfd): add LS reminder indicator #9668

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

BravoMike99
Copy link
Contributor

@BravoMike99 BravoMike99 commented Dec 16, 2024

Fixes #[issue_no]

Summary of Changes

Adds xLS reminder on the PFD

Screenshots (if necessary)

image
image

References

Additional context

Discord username (if different from GitHub):
bruno_pt99

Testing instructions

For both A32NX & A380X:

  1. Select an ILS approach in the MCDU.
  2. Once in the air and with approach phase active, press the APPR mode on the FCU without the "LS" button pressed on the EFIS control panel.
  3. Amber "ILS" (A32NX)/ "LS"(A380X) should blink on the bottom right of the PFD and then stop after 9 seconds.
  4. Once LS button is pushed on the associated side, the amber indication disappears

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@BravoMike99 BravoMike99 marked this pull request as ready for review December 17, 2024 22:35
@BravoMike99 BravoMike99 added A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft labels Dec 17, 2024
@G-DRAW
Copy link

G-DRAW commented Dec 18, 2024

Aircraft Version
Stable

Build info
"v0.12.0"
Describe the bug
When doing an ILS approach in the A380, and the LS P/B's on EFIS is not turned ON, the LS will constantly flash in amber which is correct, but doesn't automatically display the lateral and vertical deviation scales when LOC or APPR Mode is armed.

Expected behavior
If LS P/B isn't selected when doing an ILS approach, it would automatically display the LOC and G/S deviation scales on both PFD's after arming the LOC P/B or APPR P/B, and the LS P/B's would automatically light up.
Landing System Scales
Landing System Scales

Steps to reproduce
Setup an ILS approach anywhare you want and conduct approach.
leave LS P/B's off.
Check that amber LS is flashing when getting nearer to runway.
ARM LOC P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS.
Deselect LOC
Also turn off LS P/B's on both EFIS.
Check that amber LS is flashing when getting nearer to runway.
ARM APPR P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS.

For A320 it's different.

@BravoMike99
Copy link
Contributor Author

Aircraft Version Stable

Build info "v0.12.0" Describe the bug When doing an ILS approach in the A380, and the LS P/B's on EFIS is not turned ON, the LS will constantly flash in amber which is correct, but doesn't automatically display the lateral and vertical deviation scales when LOC or APPR Mode is armed.

Expected behavior If LS P/B isn't selected when doing an ILS approach, it would automatically display the LOC and G/S deviation scales on both PFD's after arming the LOC P/B or APPR P/B, and the LS P/B's would automatically light up. Landing System Scales Landing System Scales

Steps to reproduce Setup an ILS approach anywhare you want and conduct approach. leave LS P/B's off. Check that amber LS is flashing when getting nearer to runway. ARM LOC P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS. Deselect LOC Also turn off LS P/B's on both EFIS. Check that amber LS is flashing when getting nearer to runway. ARM APPR P/B - and check that LS deviation scales automatically appear, and LS P/B lights up on both EFIS.

For A320 it's different.

The original purpose of this PR is to just add the LS indicator on the PFD. The automatic LS selection is left for future work and should be addressed in a further PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft
Projects
Status: 🟡 Code Review: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants