fix(fws): Sound scheduling for FWS, triple click on capability downgrade

[flogross89]

Fixes #9008
Fixes #7710

Summary of Changes

Rework of some FWS parts for A32NX and A380X concerning sound scheduling.

A32NX + A380X:

• Adds proper triple click logic: Triple click is scheduled for playback if approach capability is downgraded. Around 1 seconds debouncing and 3 sec suppression after a downgrade, since our downgrade from CAT3D to CAT 1 takes quite a while

A380X:

• Move all relevant sounds (ROP/ROW, autobrake off, AP/ATHR disc., triple click, altitude callouts) to FwsSoundManager

A32NX:

• Add "autobrake off" callout
• Refine AP/ATHR disconnection logic
• Move some, but not all relevant sounds (autobrake off, AP/ATHR disc., triple click) to FwsSoundManager

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

A32NX:

• Prepare normal A-B flight & take off
• Disconnect AP and A/THR multiple times during the flight
• a. By using a joystick and the AUTOPILOT/AUTOTHROTTLE OFF/DISCONNECT bindings. One press should trigger an AP OFF ECAM memo and an aural cavalry charge, a second press within 0.8s should silence it. If you wait longer than 0.8s with the second press, you should get a continuous cavalry charge, an ECAM memo and an ECAM fault "AP OFF"
• b. By clicking the AP push button on the FCU. This should trigger a continuous cavalry charge, an ECAM memo and an ECAM fault "AP OFF"
  -->Triple clicks should not be heard when disconnecting the AP outside of an ILS approach
• Ensure that altitude c-chord (when leaving FCU altitude) works as expected
• Fly an ILS approach, engage both APs. Try various engage/disengage conditions. When the landing capability degrades, a triple click should be heard
• Land with engaged auto brake mode. Disconnect auto brake above 50kts, an "auto brake off" callout should be heard

A380X:
Try to trigger all of these callouts and confirm that they still sound as expected:
V1, autobrake off, AP disconnect, A/THR deactivation, altitude callouts, triple clicks, GPWS (terrain/pull up, ...)

Triple clicks shouldn't trigger for every AP disconnect, but only when the landing capability degrades.
Ensure that altitude c-chord (when leaving FCU altitude) works as expected

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

1. Make sure you are signed in to GitHub
2. Click on the Checks tab on the PR
3. On the left side, find and click on the PR Build tab
4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

[flogross89]

@2hwk Thanks for the review, just pushed some changes and left comments

[BravoMike99]

Just some small FWS logic comments due to differences vs the A380.

stale

[BravoMike99]

Quality Assurance Tester

Discord Username : bruno_pt99
Object of testing : #9555
Aircraft : A32NX
Tier of Testing : 1
Date : 23/11/2024

Testing Process:

Performed a normal flight and binded the following keys "AUTOPILOT OFF" & "AUTOTHROTTLE DISCONNECT"

1. Disconnected AP with double press in the air, 3 cavalry charges sounded and the "AP OFF" memo appeared alongside no triple click ✔️ .
2. Involuntarily disconnected the AP, AUTOFLT AP OFF appeared on the ECAM alongside "AP OFF" and the cavalry charge continued to sound till pressing the disconnect button ✔️ .
3. Disconnected ATHR via the bind, AUTO FLT ATHR OFF caution appeared instead of "ATHR OFF" memo ❌ Fixed as of 5/12
4. Tested multiple mode reversions and triple click worked ✔️
5. Left the assigned FCU altitude in level flight and the Chord sounded ✔️
6. During approach. Did mode reversion from CAT 3D -> CAT 3 Single, CAT 3D/3S -> CAT 2 and triple click sounded ✔️
7. After disconnecting autopilot the triple click did not seem to sound after the downgrade to CAT 1, or, it is overlapping with the cavalry charges instead of playing after them ❌ Fixed as of 5/12
8. During the flare, setting the thrust to idle triggered the AUTO FLT ATHR OFF ecam caution.❌ Unable to reproduce as of 5/12
9. Autobrake OFF callout sounded above 50kt when disconnecting autobrake ✔️

Testing Results: Passed

Negatives:

I also noticed that sometimes when going idle thrust with my hardware levers it would disconnect with the "ATHR OFF" memo while other times with the AUTOFLT ATHR off (perhaps related to hardware noise?). In addition, when the "ATHR OFF" memo was triggered, a single chime didn't sound, which it should. Unable to reproduce as of 5/12
Bonus: With the involuntary AP disconnection the ecam warning should remain there even after the takeover/disconnect button is pressed, the only way to get rid of it is via the CLR button. Currently pressing the disconnect button clears the warning. Fixed as of 5/12
Setting thrust to MCT or TOGA in the air trigerred the AUTOFLT ATHR off (see media) Fixed as of 5/12

Media:

[flogross89]

Reminder: #9615

[BravoMike99]

@BravoMike99 Thanks! Just pushed fixes for:

• single chime missing
• instinctive disconnect not recognized (involuntary triggered instead of voluntary)
  Could you try the failed ones again?

Can't explain 7. and 8. at the moment, it has the same logic as the a380x (which should work from what I know)

Just tried it again. Instinctive disconnect, single chime missing, triple click overlap & warning when going to MCT/TOGA are fixed now👍

[BravoMike99]

Quality Assurance Tester Report
Discord Username : bruno_pt99
Object of testing : #9555
Aircraft : A32NX
Tier of Testing : 2
Date : 15/12/2024

Testing Process:
Performed a full flight and tested the following:

1. Disconnecting ATHR through instinctive and non instinctive methods and checked ATHR OFF memo & AUTOFLT AUTO THRUST OFF appeared accordingly ✔️
2. Disconnected AP voluntarily. AP OFF appeared on memo and by doing a second press it disappeared. If second is not pressed quickly enough, the AUTOFLT AP OFF warning appears with a continuous cavalry charge ✔️
3. Disconnecting AP off through non voluntary means also generated a continuous cavalry charge with the AUTOFLT AP OFF ecam warning and master warning light.
4. Altitude C chord sounded when leaving the assigned FCU altitude and by pressing the master warning button it silenced ✔️
5. Tested some FG mode reversions and the triple click worked ✔️
6. Tested multiple approach capability downgrades and the triple click sounded. Disconnecting autopilot without an approach capability downgrade did not trigger a triple click.
7. Autobrake off callout sounded when disconnecting autobrake above 50kts. ✔️

Testing Results:
Passed

Media:

2024-12-15.16-36-10.mp4

2024-12-15.16-37-30.mp4

2024-12-15.16-56-20.mp4

2024-12-15.17-02-31.mp4

[BravoMike99]

Quality Assurance Tester

Discord Username : bruno_pt99
Object of testing : #9555
Aircraft : A380X
Tier of Testing : 1
Date : 18/12/2024

Testing Process:

1. Tested multiple audio warning conditions (V1, AUTOBRAKE OFF, GPWS, RA callouts, master caution, master warning ) and they all sounded ✔️
2. Triple click did not sound when disconnecting autopilot without capability downgrade ✔️
3. Triple click sounded on mode reversion & approach capability downgrade.
4. Altitude horn sounded when leaving and reaching assigned FCU altitude ✔️

Testing Results:
Passed