Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump egui to 0.30.0 #221

Merged
merged 2 commits into from
Dec 17, 2024
Merged

bump egui to 0.30.0 #221

merged 2 commits into from
Dec 17, 2024

Conversation

bircni
Copy link
Contributor

@bircni bircni commented Dec 16, 2024

No description provided.

@fluxxcode
Copy link
Owner

Thanks for the update. winit seems to be broken und linux though

@hacknus
Copy link
Contributor

hacknus commented Dec 16, 2024

we need the x11 feature on linux now, no?

@fluxxcode
Copy link
Owner

See my comment on: emilk/egui#5493 (comment)

According to emilk's comment: #5489 (comment) the wayland feature needs to be enabled for eframe. However, when the feature is enabled, I get the following compiling errors on Arch:

error: failed to select a version for the requirement `egui-wgpu = "^0.30.0"`
candidate versions found which didn't match: 0.29.1, 0.29.0, 0.28.1, ...
location searched: crates.io index
required by package `eframe v0.30.0`
    ... which satisfies dependency `eframe = "^0.30.0"` (locked to 0.30.0) of package `egui-file-dialog v0.7.0 (/home/jannis/projects/egui-file-dialog)`
if you are looking for the prerelease package it needs to be specified explicitly
    egui-wgpu = { version = "0.26.0-alpha.2" }

egui-wgpu:v0.30.0 doesn't seem to be on crates.io yet

Copy link
Owner

@fluxxcode fluxxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have permission to push on this branch, so here's a suggestion with the fix for Linux

Cargo.toml Outdated Show resolved Hide resolved
@bircni
Copy link
Contributor Author

bircni commented Dec 16, 2024

The question is - do we wanna support Wayland or x11?

@hacknus
Copy link
Contributor

hacknus commented Dec 16, 2024

shouldn't this be something that the user can select?

@fluxxcode
Copy link
Owner

fluxxcode commented Dec 16, 2024

We should support both.

Edit: updated my suggestion to also include x11

@fluxxcode
Copy link
Owner

shouldn't this be something that the user can select?

Yes, this is just for the examples

Co-authored-by: Jannis <[email protected]>
@bircni
Copy link
Contributor Author

bircni commented Dec 17, 2024

@fluxxcode we could also set this as optional dependencies?

@fluxxcode
Copy link
Owner

No, I don't think that's helpful and rather confusing. eframe is only a dev dependency for the examples and is therefore not included in normal use of the library.
The examples should work on as many systems as possible, just like a normal egui app does.

@hacknus
Copy link
Contributor

hacknus commented Dec 17, 2024

maybe document it in the examples Cargo.toml that this is required for linux?

@fluxxcode
Copy link
Owner

It is the job of eframe to document this correctly, but not of our library. The feature is an eframe feature and since our examples use eframe, we have to "configure" eframe correctly. But the problem has nothing to do with our library.

@fluxxcode
Copy link
Owner

Will merge the PR now. Thanks!

@fluxxcode fluxxcode merged commit 51be318 into fluxxcode:develop Dec 17, 2024
5 checks passed
@fluxxcode fluxxcode mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants