-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gateway-api): Add custom backendRef and filters support for HTTPRoute #1742
Open
kahirokunn
wants to merge
2
commits into
fluxcd:main
Choose a base branch
from
kahirokunn:custom-http-route
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kahirokunn
changed the title
feat: Custom BackendRef for Primary and Canary Services
[WIP] feat: Custom BackendRef for Primary and Canary Services
Dec 13, 2024
kahirokunn
force-pushed
the
custom-http-route
branch
2 times, most recently
from
December 16, 2024 02:02
b711e6d
to
df378db
Compare
kahirokunn
force-pushed
the
custom-http-route
branch
7 times, most recently
from
December 16, 2024 06:58
f89feb6
to
5931ff6
Compare
kahirokunn
changed the title
[WIP] feat: Custom BackendRef for Primary and Canary Services
[WIP] feat: Custom Backend for Primary and Canary Services
Dec 16, 2024
kahirokunn
changed the title
[WIP] feat: Custom Backend for Primary and Canary Services
feat(gateway-api): Custom Backend for Primary and Canary Services
Dec 16, 2024
kahirokunn
force-pushed
the
custom-http-route
branch
from
December 17, 2024 02:19
5931ff6
to
3cd52c0
Compare
…Route Signed-off-by: kahirokunn <[email protected]>
kahirokunn
force-pushed
the
custom-http-route
branch
from
December 17, 2024 02:35
3cd52c0
to
4f3511b
Compare
kahirokunn
changed the title
feat(gateway-api): Custom Backend for Primary and Canary Services
feat(gateway-api): Add custom backendRef and filters support for HTTPRoute
Dec 17, 2024
Dear @stefanprodan I hope this message finds you well. I am reaching out to request your review on an enhancement I am working on for the Flagger gateway API. My goal is to support the integration of Envoy Gateway with KEDA HTTPScaledObjects through this enhancement. I would greatly appreciate your feedback and insights on this matter. Thank you for your time and consideration. Best regards, |
Signed-off-by: kahirokunn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for custom backend references in Flagger's primary and canary services. This enhancement allows users to specify different routing configurations and intermediate services for primary and canary traffic, enabling more complex deployment patterns and better integration with existing infrastructure.
Key Changes
backendRef
andfilters
tospec.service.canary
andspec.service.primary
Use Cases
This feature enables several important scenarios:
Example Configuration
Breaking Changes
None. This is a backward-compatible change that maintains existing behavior when custom backend references are not specified.
Additional Context
This change also allows for cases where different backends are referenced for canary and primary, as shown in the attached image.
For details, please refer to the following PR.
#1714
Issue
#1741
TODO