Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway API: Sort header filters to avoid canary restarts #1713

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

mingjie-li
Copy link

@mingjie-li mingjie-li commented Oct 18, 2024

fix canary analysis restart with gateway api

Fix: #1712

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening this PR!

pkg/router/gateway_api.go Outdated Show resolved Hide resolved
pkg/router/gateway_api_test.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.06%. Comparing base (2d5e289) to head (b88e080).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
pkg/router/gateway_api.go 76.92% 2 Missing and 1 partial ⚠️
pkg/router/gateway_api_v1beta1.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   34.44%   35.06%   +0.61%     
==========================================
  Files         283      283              
  Lines       20691    24645    +3954     
==========================================
+ Hits         7128     8642    +1514     
- Misses      12627    15063    +2436     
- Partials      936      940       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@stefanprodan stefanprodan changed the title fix #1712 : sort gateway api header fileter to fix canary restart Gateway API: Sort header filters to avoid canary restarts Nov 1, 2024
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mingjie-li 🥇

Copy link
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@aryan9600 aryan9600 merged commit 7cd1476 into fluxcd:main Nov 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary analysis restart again and again when using Gateway API
4 participants