Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Automatic platform adaptations" page to Adaptive design section in Left Nav #11473

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

droidbg
Copy link
Contributor

@droidbg droidbg commented Dec 6, 2024

Issues fixed by this PR : #11442
This PR moves the Automatic platform adaptations page to section Adaptive & responsive design in nav bar and closes the above issue.

Presubmit checklist

@droidbg droidbg requested review from sfshaza2, parlough and a team as code owners December 6, 2024 14:27
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @droidbg! Though we also need to set up a redirect. I'll do that in a new PR.

@sfshaza2
Copy link
Contributor

sfshaza2 commented Dec 6, 2024

/gcbrun

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 6, 2024

Visit the preview URL for this PR (updated for commit 1a3de68):

https://flutter-docs-prod--pr11473-shifting-adaptaion-page-yhwk3aes.web.app

@sfshaza2
Copy link
Contributor

sfshaza2 commented Dec 9, 2024

Actually, the lack of the redirect is breaking the build. Can you add one, @droidbg? It's a single line in the firebase.json file.

@droidbg
Copy link
Contributor Author

droidbg commented Dec 10, 2024

Hi @sfshaza2, I have now added the redirect. Could you pls review this PR again.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks, @droidbg!

@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2
Copy link
Contributor

/gcbrun

@sfshaza2 sfshaza2 merged commit d6ad66f into flutter:main Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants