Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptations page has confusing leftnav position #11442

Open
mit-mit opened this issue Nov 26, 2024 · 3 comments
Open

Adaptations page has confusing leftnav position #11442

mit-mit opened this issue Nov 26, 2024 · 3 comments
Assignees
@sfshaza2
Labels
e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@mit-mit
Copy link
Member

mit-mit commented Nov 26, 2024

The page https://docs.flutter.dev/platform-integration/platform-adaptations discusses the automatic UI adaptions performed by the Flutter framework. However for some reason it is placed in the leftnav under the "Beyond UI" section in the "Platform integration" subsection. That seems confusing as all the adaptations are UI related. I suggest it should be moved to the "User Interface" section in the "Adaptive and responsive" design subsection.
@mit-mit
Copy link
Member Author

mit-mit commented Nov 26, 2024

cc @jmagman @goderbauer

@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs labels Dec 2, 2024
@sfshaza2 sfshaza2 self-assigned this Dec 2, 2024
@droidbg droidbg mentioned this issue Dec 6, 2024
Merged
3 tasks
@LukeDevNation
Copy link

Totally agree, it makes more sense for the page to be under (user interface > adaptive and responsive) since it’s all about UI adaptations. Placing it under 'Beyond UI' could confuse those looking for specific information on adaptive interfaces. It would be great to move it to make it easier to find.

@jmagman
Copy link
Member

jmagman commented Dec 10, 2024

I think it makes sense. cc @parlough who moved it there last year #9182

sfshaza2 added a commit that referenced this issue Dec 12, 2024
@droidbg @sfshaza2
Move "Automatic platform adaptations" page to Adaptive design section…
d6ad66f 
… in Left Nav (#11473)

_Issues fixed by this PR :_ #11442 
This PR moves the `Automatic platform adaptations` page to section
`Adaptive & responsive design` in nav bar and closes the above issue.

## Presubmit checklist

- [X] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [X] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [X] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfshaza2 sfshaza2

Labels
e1-hours Effort: < 8 hrs p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jmagman @mit-mit @sfshaza2 @LukeDevNation