This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how to properly build/test the project locally, I ran
yarn test:jest
and it worked, but runningyarn build:demo
would output an unexpected error about parcel and a duplicate pluginnonetheless, the change should be straigth-forward,
it's about removing a polyfill
https://www.npmjs.com/package/@hypnosphi/create-react-context
that is creating problems in modern project due to it not compiling/definingesm
module
inpackage.json
, this can usually be fixed via Aliases in project, but code-sandbox has no solution to this problem, as a result when trying to use react-popper 1.3.11 in a code-sandbox we get an errorI'm going to test this out in the project I'm working on and see if everything works as expected, if someone can provide some additional instroction on how I can make it work with flow/parcel and test it out as intended, it would be really appreciated!
N.B. I bumped the version to 1.4 because removing the polyfill could be potentially breaking for some project that are using react < 16 and depending on it...