Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_auth): Removed duplicates; fixed typos; removed "unnecessary use of a null check" #16815

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nikita0x
Copy link

@Nikita0x Nikita0x commented Dec 3, 2024

Description

Docs:
Fixing typos, removing duplicates

Code:
Removed the "unnecessary use of a null check". Actually, it wasn't me but a compiler forced me to do it!

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Nikita0x Nikita0x changed the title Removed duplicates; fixed typos; removed "unnecessary use of a null check" docs:Removed duplicates; fixed typos; removed "unnecessary use of a null check" Dec 3, 2024
@Nikita0x Nikita0x changed the title docs:Removed duplicates; fixed typos; removed "unnecessary use of a null check" docs(firebase_auth): Removed duplicates; fixed typos; removed "unnecessary use of a null check" Dec 3, 2024
@Nikita0x
Copy link
Author

I am not sure why some tests failed to be honest. I would like a help from somebody, I just changed the text in the docs mostly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant