Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(eth): attach ToFilecoinMessage converter to EthCall type #12062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor(eth): attach ToFilecoinMessage converter to EthCall type #12062

wants to merge 2 commits into from

Conversation

raulk
Copy link
Member

@raulk raulk commented May 31, 2024

Small refactor to clean things up.

  • This converter is better placed as an EthCall method instead of a package-level function.
  • The resulting package/module import graph is sane.
  • Exporting this as a public method is very helpful for those who use Lotus as a library.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 31, 2024 •
edited
Loading

All checks have passed

@raulk raulk force-pushed the raulk/refactor-eth-message branch from c538885 to 3d98bd0 Compare May 31, 2024 18:06
@jennijuju jennijuju requested a review from aarshkshah1992 May 31, 2024 20:07
@rjan90
Copy link
Contributor

rjan90 commented Jun 3, 2024

Thanks for the PR! Aarsh will do a pass on it when he is back (he is OOO today).

In the meantime, it looks like you need to run: make gen / make docsgen-cli for the two last checks there to pass.

@Stebalien
Copy link
Member

Er, sorry, I didn't see the comment from @rjan90.

@rjan90
Make gen / Make docsgen-cli
c7e8c96 
Make gen / Make docsgen-cli
@rjan90
Copy link
Contributor

rjan90 commented Jun 3, 2024

Pushed make gen / make doscgen-cli, to unblock this PR (hope that was okay Raul) so that we can merge it.

@Stebalien
Copy link
Member

Test failure looks real.

@raulk
Copy link
Member Author

raulk commented Jun 4, 2024

@rjan90 thanks for running make! ❤️
@Stebalien -- yep, it looks real. I'm investigating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@aarshkshah1992 aarshkshah1992 Awaiting requested review from aarshkshah1992

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulk @rjan90 @Stebalien