-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(finance): update mastercard patterns and test #2396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2396 +/- ##
==========================================
- Coverage 99.61% 99.60% -0.01%
==========================================
Files 2802 2802
Lines 252492 252492
Branches 1103 1103
==========================================
- Hits 251516 251500 -16
- Misses 949 965 +16
Partials 27 27
|
Please also update this new file: https://github.com/faker-js/faker/blob/next/src/locales/zh_CN/finance/credit_card/mastercard.ts |
ST-DDT
added
c: chore
PR that doesn't affect the runtime behavior
p: 1-normal
Nothing urgent
m: finance
Something is referring to the finance module
labels
Sep 17, 2023
ST-DDT
reviewed
Sep 17, 2023
ST-DDT
approved these changes
Sep 18, 2023
xDivisionByZerox
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: chore
PR that doesn't affect the runtime behavior
m: finance
Something is referring to the finance module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
#2350 (comment)
Updates the mastercard patterns to remove the weird 677189... pattern
which is identified as a unionpay card, and instead add the much more
common patterns starting 2221 – 2720 which were introduced in 2017
https://www.cardfellow.com/blog/new-mastercard-bins/
Following this change, all mastercard card numbers pass validator's
isCreditCard
check, so switch to using that instead of a custom regex