-
Notifications
You must be signed in to change notification settings - Fork 56
chore: add node badge to README #138
base: main
Are you sure you want to change the base?
chore: add node badge to README #138
Conversation
Hi @jhonatantft! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@pestevez Could you review it please? |
Apologies for the delayed response, @jhonatantft. The changes look good. Would you mind sharing how you landed at that specific version being the minimum one supported? |
@pestevez Thanks for the answer. I managed to get to that specific version by doing tests with each Node version. In the older version than this, I received several errors and was unable to use the application properly. |
I tried with version 8.11.3 (one lower than the one proposed) and it worked, but it didn't work with version 8.0.0. I am fine with keeping the one you have, since anyway the LTS version of node as of today is 14.15.5. Can you please rebase, run npm install, AND include the package-lock.json file in your PR? Thanks again. |
73c6bec
to
383c175
Compare
Done! @pestevez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @jhonatantft! Feel free to merge it.
You'll have to rebase again since we merged another PR that modified the lock file. I can take another look after you repeat the same steps described above. |
Related issue: #22
What changes this code is introducing?