This repository has been archived by the owner on Mar 3, 2020. It is now read-only.
Make game start countdown timer count down #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than being a static number updated on page refresh, the countdown clock will not update itself. This makes for a more interesting display. Using time remaining rather than an absolute time to prevent jittery behaviour at the start, though at the expense of accuracy.
JasonTarka
force-pushed
the
countdown-timer
branch
from
9bbc30c to
7d1d603
Compare
The 1000ms timeout doesn't always fire at exactly 1000ms, and over time there's enough drift to make it off by half a minute or more. Given a display running for several days, it could become off by a couple of hours.
There's no guarantee that a timeout will finish on time, and after a short period the clock becomes inaccurate. With the periodic refresh this isn't a big deal, but the countdown doesn't look as smooth as it could. By keeping track of the actual end date there will be no jumps, and it looks smoother overall. This also makes the code much easier to understand & maintain.
|
This should fix #113 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than being a static number updated on page refresh, the
countdown clock will not update itself. This makes for a more
interesting display.
Using time remaining rather than an absolute time to prevent
jittery behaviour at the start, though at the expense of accuracy.