Skip to content

Commit

Permalink
Add Hack namespace for Eden thrift files
Browse files Browse the repository at this point in the history
Summary: I want to import these into our Hack server side code so I can write Hack functions to prefetch files. Adding a Hack namespace allows me to do that without hitting classname conflicts.

Reviewed By: kmancini

Differential Revision: D49322120

fbshipit-source-id: 333e27d245c88b17bd3645cb2103ec3e6ba1f63e
  • Loading branch information
Shashank Kambhampati authored and facebook-github-bot committed Sep 16, 2023
1 parent 5c75853 commit 29271ea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions eden/fs/config/eden_config.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ namespace cpp2 facebook.eden
namespace java com.facebook.eden.thrift
namespace py facebook.eden.eden_config
namespace py3 eden.fs.config
namespace hack edenfs.config

/**
* Identifies the point of origin of a config setting. Precedence is defined by ConfigSetting::getIdx()
Expand Down
1 change: 1 addition & 0 deletions eden/fs/service/eden.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ namespace cpp2 facebook.eden
namespace java com.facebook.eden.thrift
namespace py facebook.eden
namespace py3 eden.fs.service
namespace hack edenfs.service

/**
* API style guide.
Expand Down

0 comments on commit 29271ea

Please sign in to comment.