Skip to content

Commit

Permalink
add explicit mapping of ConfigSourceType to precedence
Browse files Browse the repository at this point in the history
Summary: Code review from D37169769 - its not easy to extend implicit precedence in thrift without unsafe reordering - instead lets map this ourselves in the code

Reviewed By: xavierd

Differential Revision: D48758164

fbshipit-source-id: faab964fae19cacc681628c5f31a6bc184a9a94f
  • Loading branch information
genevievehelsel authored and facebook-github-bot committed Sep 15, 2023
1 parent 5441968 commit 1151b8f
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions eden/fs/config/eden_config.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@ namespace py facebook.eden.eden_config
namespace py3 eden.fs.config

/**
* Identifies the point of origin of a config setting. It is ordered from
* low to high precedence. Higher precedence configuration values over-ride
* lower precedence values. A config setting of CommandLine takes precedence
* over all other settings.
* Identifies the point of origin of a config setting. Precedence is defined by ConfigSetting::getIdx()
*/
enum ConfigSourceType {
Default = 0,
Expand Down

0 comments on commit 1151b8f

Please sign in to comment.