Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyscrypt dependency for macOS (fixes #332) #333

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

odkr
Copy link
Contributor

@odkr odkr commented Nov 30, 2024

I added a pyscrypt dependency when sys_platform == "darwin" (scrypt throws a build error). This fixes #332. If you either update etebase on PyPI to v31.0.8 or the build in instructions for the runner to use etebase v31.0.8, etesync-dav should build on Apple Silicon using the macOS 14 runner.

@odkr odkr changed the title Add pyscript dependency for macOS (fixes #332) Add pyscyipt dependency for macOS (fixes #332) Nov 30, 2024
@odkr odkr changed the title Add pyscyipt dependency for macOS (fixes #332) Add pyscrypt dependency for macOS (fixes #332) Nov 30, 2024
@tasn
Copy link
Member

tasn commented Dec 1, 2024

Lint is failing.

Though does this fix your issue?

@odkr
Copy link
Contributor Author

odkr commented Dec 1, 2024

Though does this fix your issue?

I'm not sure which issue your refer to. It fixes #332. You fixed etesync/etebase-py#56 by downgrading Radicale.

@tasn
Copy link
Member

tasn commented Dec 1, 2024

I mean, macOS works with this change?

@odkr
Copy link
Contributor Author

odkr commented Dec 1, 2024

I mean, macOS works with this change?

Building with EteBase 0.31.8 from https://github.com/etesync/etebase-py.git works on macOS w/ Apple Silicon:

python3 -mvenv target
. ./target/bin/activate
pip install --upgrade pip
# Install etebase 0.31.8 from GitHub
git clone https://github.com/etesync/etebase-py.git
pip install ./etebase-py
git clone -b fix-macos-scrypt https://github.com/odkr/etesync-dav.git
pip install ./etesync-dav

Building with EteBase 0.31.5 from PyPI does not (for the reason given in #328):

python3 -mvenv target
. ./target/bin/activate
pip install --upgrade pip
# Using etebase v0.31.5 from PyPI
git clone -b fix-macos-scrypt https://github.com/odkr/etesync-dav.git
pip install ./etesync-dav

@odkr
Copy link
Contributor Author

odkr commented Dec 2, 2024

It just occurred to me that was less than clear. Adding the scrypt dependency is important for EteSync DAV to work at all, but it doesn't affect the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etesync-dav 0.33.4 - Missing scrypt module on macOS
2 participants