Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tinyusb): Added esp-idf run (esp32s2) #40

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Nov 27, 2024

Requirements

Run a pytest verification for esp-idf examples with incoming changes for espressif/tinyusb.

Description

The job names were modified regarding the following naming pattern: [REPO_NAME][JOB_NAME] - [STEP_NAME]
Where:

REPO_NAME = [ESP-IDF, ESP-USB]
JOB_NAME = [Build, Run]
STEP_NAME = [build, run-target]

Limitations

  • Only for esp32s2
  • NCM device test case is ignored (runner host kernel config doesn't have the USB_G_NCM flag), so the NCM device is not appeared as eth* adapter after connection and the test "ifconfig" could not verify device presence by hardware MAC.

Breaking change

No breaking changes

Checklist

  • Pull Request name has appropriate format (for example: "fix(dcd_dwc2): Resolved address selection when several phy are present")
  • Optional: README.md updated
  • CI passing

Related issues

No related issues

@roma-jam roma-jam self-assigned this Nov 27, 2024
@roma-jam roma-jam force-pushed the ci/run_pytest_on_idf_examples branch 2 times, most recently from f84c033 to 310cd5b Compare December 4, 2024 14:51
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upload-artifact: keep the paths relative to $IDF_PATH

download-artifact: set the output path to $IDF_PATH, and the relative paths would be both based on the IDF_PATH as root directory.

please have a try.

.github/workflows/build_and_run_idf_examples.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_run_idf_examples.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_run_idf_examples.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_run_idf_examples.yml Outdated Show resolved Hide resolved
@roma-jam roma-jam changed the title ci(tinyusb): Added run pytest ci(tinyusb): Added esp-idf run (esp32s2) Dec 9, 2024
@roma-jam roma-jam force-pushed the ci/run_pytest_on_idf_examples branch from 94f043c to b9d898c Compare December 16, 2024 10:48
@roma-jam roma-jam marked this pull request as ready for review December 16, 2024 18:31
@roma-jam roma-jam force-pushed the ci/run_pytest_on_idf_examples branch from cf779ac to 45aafa6 Compare December 16, 2024 18:31
@roma-jam roma-jam force-pushed the ci/run_pytest_on_idf_examples branch from 803836b to 4f80c3c Compare December 17, 2024 09:51
@roma-jam roma-jam force-pushed the ci/run_pytest_on_idf_examples branch 2 times, most recently from a49b1b3 to ff15f39 Compare December 17, 2024 10:37
@roma-jam roma-jam force-pushed the ci/run_pytest_on_idf_examples branch from ff15f39 to d00b6b7 Compare December 17, 2024 10:47
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@roma-jam roma-jam merged commit 37995c7 into release/v0.17 Dec 17, 2024
28 checks passed
@roma-jam roma-jam deleted the ci/run_pytest_on_idf_examples branch December 17, 2024 16:21
@tore-espressif tore-espressif added this to the v0.17.1 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants