fix(websocket): propagate error type #694
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an regression from 0d8f2a6 that caused the
error_type
not to be available in the event dispatcher when auto disconnect is disabled.The
error_type
must be set for the event dispatcher to propagate the right errors in the next event. This is unrelated to whether auto disconnect is enabled or not.Related
Fixes regression #626
References #630
Testing
Test steps:
esp_websocket_client
Checklist
Before submitting a Pull Request, please ensure the following: