[examples]: Make multi-netif example working with DNS_PER_DEFAULT_NETIF #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| size_t num_of_ifaces = sizeof(ifaces) / sizeof(ifaces[0]); | ||
|
|
||
| while (true) { | ||
| // For demonstration purposes we clear DNS table every iteration to exercise |
There was a problem hiding this comment.
Could we try to move this out of a loop and have it set twice only? One with the regular expected way users would do and after that we clean and do as demo? We could consider keep the loop as is as long as we have once the expected way clearly stated.
| @@ -19,6 +19,9 @@ This example demonstrates working with multiple different interfaces with differ | |||
| * It tries to reconfigure DNS server if host name resolution fails | |||
| * It tries to manually change the default interface if connection fails | |||
|
|
|||
| This example demonstrate how DNS servers could be handled on network interface level, as lwIP used global DNS server information. All network interfaces store the DNS info upon acquiring an IP in the internal structure and the DNS servers are restored if host name resolution fails. | |||
There was a problem hiding this comment.
It might be worth to add a subsection for the DNS part to improve reading.
| @@ -1,2 +1,5 @@ | |||
| # You can use CONFIG_ESP_NETIF_SET_DNS_PER_DEFAULT_NETIF | |||
There was a problem hiding this comment.
Do we expect this to be the default for users? If so, we should enable it here and point in README how to disable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest IDF supports
CONFIG_ESP_NETIF_SET_DNS_PER_DEFAULT_NETIFconfig option which restores global DNS server information from "per-netif" records whenever a new netif is selected for routing (set as default).