feat(websocket): interruptable wait timeout #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erkia
force-pushed
the
ws-wait-timeout-intr
branch
from
0625628 to
0ccc3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, websocket automatic reconnect delay is implemented using simple
vTaskDelay(client->wait_timeout_ms / 2 / portTICK_PERIOD_MS). This has two drawbacks:esp_websocket_client_stop()while delay is active will block until (half) reconnect delay is passed, which is especially annoying when delay is long.This pull requests uses task notifications to wake up websocket task from reconnect delay when necessary.