-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional 2nd package to add radar and battery sensors to esp32-s3-box-3.yaml #165
base: main
Are you sure you want to change the base?
Conversation
To be added as an extra package in addition to the main esp32-s3-box-3.yaml Provides --------- Sensors: - battery voltage (hidden) - battery level % Binary Sensor: - Presence detect (occupancy) Number: - Presence duration (timeout to keep Presence detect true, default 300 seconds) Switch: - Mute when absent (microphone and backlight off for low power)
I like this. I think we should move it out of this folder though as it can just be used generically for any s3-box-3 and doesn't need to be for voice-assistants. Jesse |
I and others have had this running for several weeks now with some battery calibration performed from 2 separate users. I think having it as a package will make it an easy optional addition for those using the sensor dock. |
Ah ok. I'll move it to the voice-assistant folder then... |
Move to more generic folder
Development recorded here: |
Presently testing the compile with the yaml: substitutions:
name: esp32-s3-box-3-5ad0fc
friendly_name: Jarvis
micro_wake_word_model: hey_jarvis
packages:
esphome.voice-assistant: github://esphome/firmware/wake-word-voice-assistant/esp32-s3-box-3.yaml
esphome.voice-assistant-sensor: github://jaymunro/esphome_firmware/voice-assistant/esp32-s3-box-3-sensor.yaml@sensor_dock
esphome:
name: ${name}
name_add_mac_suffix: false
friendly_name: ${friendly_name}
api:
encryption:
key: xxxxxxxxxxxxxxxxxxxxxx=
wifi:
ssid: !secret wifi_ssid
password: !secret wifi_password |
Looking at your comment again @jesserockz, I think battery and radar stuff can be pulled out to an even more generic location (where?), but the Where ever the others are moved to, the |
Ah yes good point. I think all the actual sensors could go in one file and mute on a sense could just be documented somewhere that people can add to their adopted yaml even alongside the package line they are already adding |
I've been looking through the file structure and it seems the only location for box3 firmware is inside the voice-assistant folders. As these sensors only work with the TLDNR: Presently there is no generic location that I can see. Is there presently a non VA use for the Box3 with sensor dock in ESPHome? |
Perhaps, what could be done is the basic functionality could be modified to be a stand-alone package and go into How then could this be made obvious to people setting up a box3 with sensor dock as a VA? Can an alias/link/shortcut to that file be put in the voice-assistant folder? Probably not best though imo as additions to it in the future that would work stand alone without VA, may conflict with VA. I am thinking of the i2c bus for temp and humidity as a very good example (there is a serious conflict with VA). The resolution then may be just to have two versions, one in web tools, the other in voice-assistant (and maybe another in wake-word-voice-assistant?? So that people going for the micro wake word know that the sensor dock components will be compatible). I am adding lines at the start to make it stand alone for web tools. I can also add the i2c bus with temp & humidity to it as they work and without VA present, VA will not self destruct. Thoughts? |
update name and friendly_name substitutions to add `Sensor`
My further thoughts are that although adding a generic firmware for the box3 sensor dock could be useful for someone, I actually put the package together for VA based on a number of forum comments requesting the radar sensor so the box:
Can we think about adding it as it is so that people waiting for it can use it now? The addition to web-tools sounds like a whole new project as there are people wanting to add TH and screen interaction that conflicts with VA. |
Generic template to give battery level and radar on the sensor dock of the box 3
Add comments on purpose and use
added clarification that it is for the radar and battery in the sensor dock.
I'm unclear as to what the difference/purpose of the I have also added comments to the voice-assistant version in the |
I would suggest that we create a new firmware folder. Each folder has a purpose and we don't want to mix it up. |
Can you clarify Paulus? Do you mean for the generic firmware or the voice-assistant specific one? Or are you suggesting putting both in a folder like |
@balloob @jesserockz , I have created a new folder
If that makes better sense, it should be ready to go. |
Change battery level % to whole numbers only to reduce recorder usage.
fix indentation
linting fixes
comment indentation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Suggestions committed
@jesserockz, did my last changes meet what you were asking for? |
publish initial state of radar on start up to counter the device starting up muted.
Hey @jaymunro - I'm trying out your custom YAML and so far so good with everything except the battery sensors, I get |
Any chances we could get this fixed and merged soon? |
thanks man. silly question, since this morphed into a one-stop-shop extra yaml for the dock, does it make sense to include the temp & humidity sensors from esphome/feature-requests#2472 as well? no idea on the ir transmitter/receiver functionality and how to interact with it, but this is more-than-enough-for-now for a casual user to get a lot of mileage from their devices |
To be added as an extra package in addition to the main esp32-s3-box-3.yaml, e.g.
All additions only use GPIO pins. I2C bus is not touched so it is very low resource usage.
Provides
Sensors:
Binary Sensor:
Number:
Switch: