New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: safe tx hash replacement #892

Open

TateB wants to merge 1 commit into main from fix/safe-race-cond

Collaborator

TateB commented Oct 3, 2024

previously when using safe, the safe transaction hash was not being updated to the normal transaction hash once it was found. this lead to a race condition in the etherscan transaction finder logic since the transaction hash at the expected nonce of the transaction was mismatched, so the transaction would be updated to show as failed.

changes:

update safe transaction hash => transaction hash through a repriced onReplaced callback


          fix: safe race condition

604a886

TateB requested a review from sugh01 as a code owner

October 3, 2024 22:59

sonarqubecloud bot commented Oct 3, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet