Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose BiQuad Q #786

Draft
wants to merge 2 commits into
base: emuflight-1.0.0-master
Choose a base branch
from

Conversation

nerdCopter
Copy link
Member

This pull request allows the ability to choose your q value for the biquad filter. Filters with a higher q will have a steeper cutoff at the cutoff freq, and a lower q has more of a roll off. The lower q will lead to less ringing and more linear changes in phase delay and frequency. Higher q will have your phase delay more abrupt. A q of 71 (will turn into 0.71) approximates butterworth filter response, and a q of 57 (0.57) will approximate bessel filter response.

@nerdCopter nerdCopter requested a review from Quick-Flash March 29, 2022 19:46
@nerdCopter nerdCopter marked this pull request as draft May 2, 2022 13:17
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch from 07ddd2b to 7015291 Compare May 22, 2022 20:05
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Choose_BiQuad_Q branch from ce46321 to 8ac3b2d Compare May 26, 2022 13:30
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch from 7015291 to 4a922e6 Compare May 26, 2022 15:47
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Choose_BiQuad_Q branch from 8ac3b2d to ac64520 Compare May 26, 2022 15:50
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch from 4a922e6 to 64a1957 Compare May 31, 2022 16:09
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Choose_BiQuad_Q branch from ac64520 to 77d9aab Compare June 2, 2022 15:03
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch 2 times, most recently from 0c4ee8b to 3aab740 Compare June 11, 2022 20:52
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Choose_BiQuad_Q branch from 77d9aab to 000931e Compare July 6, 2022 16:23
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch from 3aab740 to e86e758 Compare July 15, 2022 14:16
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Choose_BiQuad_Q branch from 000931e to 490fbd4 Compare July 15, 2022 14:47
@nerdCopter nerdCopter force-pushed the emuflight-1.0.0-master branch 2 times, most recently from fe70257 to fe7710c Compare November 22, 2022 19:11
@nerdCopter nerdCopter force-pushed the 20220329_cherry_pick_Choose_BiQuad_Q branch from 490fbd4 to 052c7e6 Compare November 22, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants