Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "forward x11 and wayland features to glutin" (#5391) #5488

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Revert "forward x11 and wayland features to glutin" (#5391) #5488

merged 1 commit into from
Dec 16, 2024

Conversation

emilk
Copy link
Owner

@emilk emilk commented Dec 16, 2024

@emilk emilk added bug Something is broken urgent We should fix this ASAP eframe Relates to epi and eframe native-linux Problem specific to Linux labels Dec 16, 2024
@emilk emilk marked this pull request as draft December 16, 2024 18:00
emilk added a commit to emilk/eframe_template that referenced this pull request Dec 16, 2024
@emilk
Try out emilk/egui#5488
1d92a49
@emilk emilk mentioned this pull request Dec 16, 2024
Closed
@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/5488-emilkrevert-x11-wayland-stuff
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@emilk
Copy link
Owner Author

emilk commented Dec 16, 2024 •
edited
Loading

Confirmed that this unbreaks eframe 0.30:

@emilk emilk marked this pull request as ready for review December 16, 2024 18:19
@emilk emilk changed the title Revert "forward x11 and wayland features to glutin" #5391 Revert "forward x11 and wayland features to glutin" (#5391) Dec 16, 2024
@emilk emilk merged commit adfc0be into master Dec 16, 2024
50 checks passed
@emilk emilk deleted the emilk/revert-x11-wayland-stuff branch December 16, 2024 18:25
@emilk
Copy link
Owner Author

emilk commented Dec 16, 2024

EDIT: the fix is to add "wayland" as a feature AND update to Rust 1.81

this revert can be reverted (will do, with some added docs to boot)

emilk added a commit that referenced this pull request Dec 16, 2024
@emilk
Revert "Revert "forward x11 and wayland features to glutin" (#5391) (#…
722dc67 
…5488)"

This reverts commit adfc0be.
@emilk emilk mentioned this pull request Dec 16, 2024
Merged
emilk added a commit that referenced this pull request Dec 17, 2024
@emilk
Revert "Revert "forward x11 and wayland features to glutin" (#5391)" (#…
cfc341f 
…5490)

* #5391
* #5488
* #5490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something is broken eframe Relates to epi and eframe exclude from changelog native-linux Problem specific to Linux urgent We should fix this ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emilk