Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export TestLoader #1183

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Export TestLoader #1183

merged 1 commit into from
Dec 18, 2024

Conversation

ef4
Copy link
Collaborator

@ef4 ef4 commented Dec 18, 2024

Apparently other packages (like ember-exam) rely on extending TestLoader. There's no reason we can't keep exporting it. Although those packages are advised they should stop relying on AMD-dependent APIs like that or they're going to prevent apps from using Vite, etc.

Apparently other packages (like ember-exam) rely on extending `TestLoader`. There's no reason we can't keep exporting it. Although those packages are advised they should stop relying on AMD-dependent APIs like that or they're going to prevent apps from using Vite, etc.
@ef4 ef4 merged commit a70adfd into main Dec 18, 2024
16 checks passed
@ef4 ef4 deleted the export-test-loader branch December 18, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants