Allow rustic-compile to accept a command argument #59
Conversation
|
Looking at the tests from the PR, this function was not intended to be an analog to The code is not entirely self-consistent, with this call trying to pass a command. But that code path is never reached. |
CeleritasCelery
force-pushed
the
rustic-compile-fix
branch
3 times, most recently
from
43a1e6b to
a598553
Compare
Previous it required binding compilation-arguments to pass an arg to it.
CeleritasCelery
force-pushed
the
rustic-compile-fix
branch
from
a598553 to
9237c94
Compare
| (while (eq (process-status proc) 'run) | ||
| (sit-for 0.1)) | ||
| (should (string= compilation-directory dir)) | ||
| (let ((proc (rustic-recompile))) |
There was a problem hiding this comment.
Why are we doing rustic-recompile here ? From a quick look the previous code doesn't seem to have it.
There was a problem hiding this comment.
The previous code does have it
rustic/test/rustic-compile-test.el
Line 98 in 0d79e4c
There was a problem hiding this comment.
I added a new test for compiling interactively rather than via lisp, so the diff looks a little weird.
| (compilation-read-command (or (car compilation-arguments) | ||
| (rustic-compile-command))) | ||
| (rustic-compile-command)))) | ||
| (rustic-set-compilation-arguments command) |
Fixes #57