Wait for solver process on drop #33
Draft
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think something funny might be going on with this PR, the tests hung for two hours. Would you mind running the test suite locally to see if you can reproduce that? |
Yeah I'll take a look. Sorry about that. I have a fork with a change similar to this mmcloughlin@2e8f636 that has mitigated the zombie child processes problem I was seeing, but that was combined with ending the session with I think we may need to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the child process when
Solveris dropped.Rust
std::process::Childdoes not kill on drop. Without waiting on the solver process, a program that spins up manyeasy-smtcontexts can leave zombie solver child processes.