Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: using {active, 100} instead of recv #88

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

tsloughter
Copy link
Member

A few quick benchmarks just on my laptop with wrk showed a consistent improvement over use of recv.

I'd like to try some more values of n including {active, once} both just to see if there are any clear differences and to tune the default. (Oh right, need to make n overridable as well before this is ready for possible merge.)

@tsloughter tsloughter requested review from yurrriq and a team June 23, 2020 22:57
@yurrriq
Copy link
Member

yurrriq commented Feb 2, 2021

This needs a rebase of course, but would be nice to sneak into 4.0. Conceptually I'm down, so long as it's configurable in the end.

Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase (onto main) and the ability to set n, otherwise looking good

@yurrriq yurrriq added the 4.0 label Feb 2, 2021
@yurrriq yurrriq mentioned this pull request Feb 2, 2021
@tsloughter
Copy link
Member Author

Cool. I'd like to get some performance testing done. This is a major change since elli wasn't even use {active, once} before.

This might be more useful in like http2 (plan to try it in chatterbox) or streaming http1 requests. When a body size is available it might be better to keep it as just calling recv with that size. Or maybe it isn't since it would be able to start receiving the next requests headers and body instead of blocking... I don't know, need performance tests :(

@yurrriq
Copy link
Member

yurrriq commented Feb 2, 2021

let's not rush it

@yurrriq yurrriq added 5.0 and removed 4.0 labels Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants