Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for stylus detection #70

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Add check for stylus detection #70

merged 6 commits into from
Dec 17, 2024

Conversation

stsdc
Copy link
Member

@stsdc stsdc commented Dec 16, 2024

This should prevent a crash of Settings, when Stylus in null.

@stsdc stsdc requested a review from a team December 16, 2024 10:39
src/Views/StylusView.vala Outdated Show resolved Hide resolved
@alainm23
Copy link

alainm23 commented Dec 16, 2024

I don't have a Wacon to test, but at the coding level it's fine. Good work.

@alainm23
Copy link

alainm23 commented Dec 16, 2024

@stsdc It would be good if you update the metainfo file and the version referencing the Issue.

@stsdc stsdc requested a review from lenemter December 17, 2024 16:42
data/wacom.metainfo.xml.in Outdated Show resolved Hide resolved
@stsdc stsdc requested a review from alainm23 December 17, 2024 17:45
@stsdc stsdc merged commit 45a453b into main Dec 17, 2024
4 checks passed
@stsdc stsdc deleted the stsdc/fix-stylus-not-detected branch December 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on the Wacom plug crushes Settings, because stylus is not detected by libwacom
3 participants