Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinebookpro: Fix build failing #734

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ryonakano
Copy link
Contributor

This PR fixes building the image for Pinebook Pro failing (see #731 (comment)).

Changes Summary

  • Fix dead link to TF-A tarball
    • Tagged tarballs available on official Gitiles seems to be generated on every download, which means timestamp differs on every download and can't use sha256sum to validate. This is the reason why I replaced to the link on GitHub mirror.
  • Add patches to TF-A to fix build error on OS 8 RC
  • Update Linux kernel config because there seems to be new options and I was asked when the build script runs make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- oldconfig
  • Use artifacts dir which is in the .gitignore

@ryonakano
Copy link
Contributor Author

I built this branch natively on my OS 8 RC and confirmed this generates a Pinebook Pro image. However, I can't test if the generated image works as expected because I don't have a Pinebook Pro.

@davidmhewitt @stsdc Do you have a PineBook Pro? If so, would you build this branch and check if the generated image is bootable on it?

@ryonakano ryonakano marked this pull request as ready for review November 4, 2024 13:12
@ryonakano

This comment was marked as resolved.

@ryonakano

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants