feat: Added support for hot reloading #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnitkun
changed the title
arnitkun
changed the title
erickzhao
requested changes
Oct 11, 2019
There was a problem hiding this comment.
Hey @arnitkun, it seems like this hot reload PR is applying nodemon to the npm start command to run Fiddle itself. However, the original issue was asking for hot reloading on the executing of the Electron code itself within Fiddle.
The solution to the problem would probably require a fundamentally different solution, either through a library like electron-reload(https://github.com/yan-foto/electron-reload) or a bespoke implementation that watches the source files using chokidar or a similar library.
|
Hey @arnitkun, I'll be closing this PR for the time being, since the base solution is not what we're looking for. Feel free to let us know if you want to keep working on this. |
|
Agreed. Had too much on my hands now. I will try to do it in a month or two.
…On Wed, Nov 6, 2019, 00:22 Erick Zhao ***@***.***> wrote:
Closed #265 <#265>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#265?email_source=notifications&email_token=ADTSNP73OCXBY3M5XHIG56DQSG6H5A5CNFSM4I74FH5KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUVA5OTA#event-2772555596>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADTSNPZYX3ZJYACHRPDKO5DQSG6H5ANCNFSM4I74FH5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67 using nodemon to hot reload.