Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecated Tooltip and Popover components with Tooltip2 … #1667

Conversation

Santhoshmani1
Copy link
Contributor

Closes #1095

fix: Replace deprecated Tooltip and Popover components with Tooltip2

  • Replaced the Popover component in the src/renderer/components/commands-action-button.tsxto Popover2 and
  • Tooltip components in the src/renderer/components/settings-electron.tsx & src/renderer/components/version-select.tsx to Tooltip2.

@Santhoshmani1 Santhoshmani1 requested review from codebytere and a team as code owners December 15, 2024 03:48
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be updated; the changes are also not drop-in and likely require other refactoring!

@Santhoshmani1
Copy link
Contributor Author

Santhoshmani1 commented Dec 17, 2024

I have updated the snapshots to correctly test for Tooltip2 components and also gone through the Tooltip2 & Poppver2 migration guide to see any additional changes required for the project which needs to be done.

@coveralls
Copy link

Coverage Status

coverage: 87.604% (+0.007%) from 87.597%
when pulling b26dd2d on Santhoshmani1:fix/Deprecated-tooltip-and-popover-components
into 73dc55e on electron:main.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Thanks for the contribution @Santhoshmani1!

@erickzhao erickzhao merged commit 9eb162c into electron:main Dec 17, 2024
9 checks passed
@Santhoshmani1 Santhoshmani1 deleted the fix/Deprecated-tooltip-and-popover-components branch December 18, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip component is deprecated in Blueprint
4 participants