fix: improve behavior with regard to sync with system theme #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsanders11
force-pushed
the
fix/default-theme
branch
from
bd4fecc to
cbf60fb
Compare
dsanders11
changed the title
dsanders11
force-pushed
the
fix/default-theme
branch
from
cbf60fb to
3572c91
Compare
dsanders11
changed the title
BlackHole1
approved these changes
Dec 9, 2024
ckerr
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1658
Fixes #1657
This fixes a couple of issues, cleans up the relevant code, and improves the UX. See issues above for specifics of what is fixed here.
We had logic distributed in multiple places to fall back to
defaultDarkif no theme was set (like on initial install) so this PR refactors that to be at a higher level and avoids an unnecessary IPC call to the main process on initial install.Improves UX by retaining the user's selected theme regardless of what state the "Sync theme with system setting" checkbox is in. Previously the theme selection dropdown would snap to whatever the system theme at the time was. Now the theme selection remains static and checking/unchecking the checkbox merely updates the theme to match the system, which is more intuitive than the theme selection changing by itself.