Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick df77f100c3c2 from chromium #44975

Open
wants to merge 1 commit into
base: 33-x-y
Choose a base branch
from

Conversation

VerteDinde
Copy link
Member

Remove GestureListenerManager as observer before destruction

GestureListenerManager adds itself as InputEventObserver but doesn't
remove itself from the observer list when getting destroyed, which
causes dangling raw pointer failures (use-after-free) if
GestureListenerManager gets destroyed before RenderWidgetHost and
dangling raw pointer checks are enabled.

Thus remove GestureListenerManager as observer when
GestureListenerManager is destructed.

Fixes regression from the following change:
https://chromium-review.googlesource.com/c/chromium/src/+/5887051

Change-Id: Ia24a0d4b80533e3a6406e7398351f37c682211fe

Bug: 378464985
Change-Id: Ia24a0d4b80533e3a6406e7398351f37c682211fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6012419
Reviewed-by: Bo Liu [email protected]
Commit-Queue: Olle Liljenzin [email protected]
Reviewed-by: Yaron Friedman [email protected]
Cr-Commit-Position: refs/heads/main@{#1386220}

Notes: Backported fix for 378464985.

@VerteDinde VerteDinde requested a review from a team as a code owner December 9, 2024 20:06
@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 33-x-y labels Dec 9, 2024
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Dec 9, 2024
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch fails to apply:

Applying: Remove GestureListenerManager as observer before destruction
Patch failed at 0139 Remove GestureListenerManager as observer before destruction
When you have resolved this problem, run "git am --continue".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
33-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants