-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x](backport #4168) Replace most context.TODO calls, comment on other Background and TODOs #4180
Conversation
Cherry-pick of cf41f38 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏 |
This pull request is now in conflicts. Could you fix it @mergify[bot]? 🙏
|
Quality Gate passedIssues Measures |
What is the problem this PR solves?
Replace use of context.TODO and context.Background from most use cases
Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragments
using the changelog toolRelated issues
This is an automatic backport of pull request Replace most context.TODO calls, comment on other Background and TODOs #4168 done by Mergify.