Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #42097) test: sync access to countRun counter in TestRunnerFactory #42129

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 19, 2024

Proposed commit message

countRun is incremented and checked in different goroutines

to avoid race conditions, only mark the workgroup as done after incrementing the counter

==================
WARNING: DATA RACE
Read at 0x00c000358fc8 by goroutine 10:
  github.com/elastic/beats/v7/filebeat/input/v2/compat.TestRunnerFactory_CheckConfig.func2()
      github.com/elastic/beats/v7/filebeat/input/v2/compat/compat_test.go:127 +0xa31
  testing.tRunner()
      testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      testing/testing.go:1743 +0x44

Previous write at 0x00c000358fc8 by goroutine 14:
  github.com/elastic/beats/v7/filebeat/input/v2/compat.TestRunnerFactory_CheckConfig.func2.1.2()
      github.com/elastic/beats/v7/filebeat/input/v2/compat/compat_test.go:89 +0x4f
  github.com/elastic/beats/v7/filebeat/input/v2/internal/inputest.(*MockInput).Run()
      github.com/elastic/beats/v7/filebeat/input/v2/internal/inputest/inputest.go:80 +0x124
  github.com/elastic/beats/v7/filebeat/input/v2/compat.(*runner).Start.func1()
      github.com/elastic/beats/v7/filebeat/input/v2/compat/compat.go:136 +0x3c7

Goroutine 10 (running) created at:
  testing.(*T).Run()
      testing/testing.go:1743 +0x825
  github.com/elastic/beats/v7/filebeat/input/v2/compat.TestRunnerFactory_CheckConfig()
      github.com/elastic/beats/v7/filebeat/input/v2/compat/compat_test.go:67 +0x56
  testing.tRunner()
      testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      testing/testing.go:1743 +0x44

Goroutine 14 (finished) created at:
  github.com/elastic/beats/v7/filebeat/input/v2/compat.(*runner).Start()
      github.com/elastic/beats/v7/filebeat/input/v2/compat/compat.go:133 +0x16f
  github.com/elastic/beats/v7/filebeat/input/v2/compat.TestRunnerFactory_CheckConfig.func2()
      github.com/elastic/beats/v7/filebeat/input/v2/compat/compat_test.go:116 +0x7a9
  testing.tRunner()
      testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      testing/testing.go:1743 +0x44
==================
--- FAIL: TestRunnerFactory_CheckConfig (0.00s)
    --- FAIL: TestRunnerFactory_CheckConfig/does_not_cause_input_ID_duplication (0.00s)
        testing.go:1399: race detected during execution of test

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #42097 done by [Mergify](https://mergify.com).

countRun is incremented and checked in different goroutines

to avoid race conditions, only mark the workgroup as done after
incrementing the counter

(cherry picked from commit 7411cc4)
@mergify mergify bot added the backport label Dec 19, 2024
@mergify mergify bot requested a review from a team as a code owner December 19, 2024 22:08
@mergify mergify bot requested review from mauri870 and removed request for a team December 19, 2024 22:08
@mergify mergify bot requested a review from faec December 19, 2024 22:08
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 19, 2024
@botelastic
Copy link

botelastic bot commented Dec 19, 2024

This pull request doesn't have a Team:<team> label.

@kruskall kruskall enabled auto-merge (squash) December 19, 2024 23:25
@kruskall kruskall merged commit d860478 into 8.x Dec 19, 2024
30 checks passed
@kruskall kruskall deleted the mergify/bp/8.x/pr-42097 branch December 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant