[javascript][v8] Support for swig 4.1.0 #703
Open
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nxhack
force-pushed
the
cleanup_V8_MAJOR_VERSION
branch
from
02a8d1c to
5ff0bb4
Compare
In swig 4.1.0, the complicated handling of "SWIG_V8_VERSION" has been cleaned up a bit. I made the same changes as in this swig. Signed-off-by: Hirokazu MORIKAWA <[email protected]>
nxhack
force-pushed
the
cleanup_V8_MAJOR_VERSION
branch
from
5ff0bb4 to
c7d7718
Compare
Propanu
approved these changes
May 21, 2021
|
hi @nxhack @Propanu Checked with node 16.11.0 swig 4.1.0 -> does not work properly due to faulty call to nodeJS function available starting with C++14
Compilation finished only with warnings or mraa see #1064 and here for upm (Raspberry Pi 4(32bit) -3P-3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for swig 4.1.0
In swig 4.1.0, the complicated handling of "SWIG_V8_VERSION" has been cleaned up a bit. I made the same changes as in this swig.
Signed-off-by: Hirokazu MORIKAWA [email protected]