Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setLimitRange() method to the IAxis interface #430

Closed
wants to merge 5 commits into from

Conversation

QuocDoBV
Copy link
Contributor

@QuocDoBV QuocDoBV commented Dec 11, 2024

Add setLimitRange() method to the IAxis interface

@QuocDoBV QuocDoBV changed the title Add setLimit() method to the IAxis interface Add setLimitRange() method to the IAxis interface Dec 11, 2024
@eselmeister
Copy link
Contributor

@QuocDoBV Did you use the same credentials as in the PR before? The ECA check fails currently.

Rerun to fix the failed ECA
@QuocDoBV
Copy link
Contributor Author

@QuocDoBV Did you use the same credentials as in the PR before? The ECA check fails currently.

I don't change ECA recently. I am trying to fix the ECA check.

@eselmeister
Copy link
Contributor

@QuocDoBV You need to sign the commit with the email used in the ECA. If you use another email in the commit, then the ECA check fails.

@QuocDoBV
Copy link
Contributor Author

@QuocDoBV You need to sign the commit with the email used in the ECA. If you use another email in the commit, then the ECA check fails.

I have updated the email to the same as the last PR but the ECA still have not fixed yet.
image
image

@eselmeister
Copy link
Contributor

eselmeister commented Dec 12, 2024

@QuocDoBV The easiest if you skip this PR and create a new one. Take care that the commit is signed off with your username QuocDoBV and email @users.noreply.github.com used in the ECA.

@QuocDoBV
Copy link
Contributor Author

@QuocDoBV The easiest if you skip this PR and create a new one. Take care that the commit is signed off with your username QuocDoBV and email @users.noreply.github.com used in the ECA.

Thank you, I will close this PR and create a new one instead.

@QuocDoBV QuocDoBV closed this Dec 12, 2024
@Mailaender
Copy link
Contributor

@users.noreply.github.com is just what the @github interfaces shows for privacy reasons. You need to state your real e-Mail address. Use git-commit --author to change the e-Mail of an existing commit.

@QuocDoBV
Copy link
Contributor Author

@users.noreply.github.com is just what the @github interfaces shows for privacy reasons. You need to state your real e-Mail address. Use git-commit --author to change the e-Mail of an existing commit.

Thank you for your advice! I have resolved them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants