Create propagatable connection, add Transaction accessor #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Sep 9, 2022
vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/PoolImpl.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Sep 13, 2022
vertx-sql-client/src/main/java/io/vertx/sqlclient/impl/PoolImpl.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Sep 16, 2022
…dhere to code style guidelines
vietj
reviewed
Sep 28, 2022
vertx-sql-client/src/main/java/io/vertx/sqlclient/SqlConnection.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Sep 28, 2022
vertx-sql-client/src/main/java/io/vertx/sqlclient/TransactionMode.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Sep 28, 2022
vertx-sql-client/src/main/java/io/vertx/sqlclient/TransactionMode.java
Outdated
Show resolved
Hide resolved
|
@vietj is this still of any interest? If not then I'll just close it. |
|
let me check, this PR was just forgotten |
|
I believe it remains something we want, we just don't agreed on the naming. I'm not a fan of TransactionMode because it is too generic, I think instead we should rename |
|
I took the liberty to rename the constants too, let me know if you don't like the new ones. |
|
thanks for the contribution |
|
This is a helpful capability. Thank you for this enhancement. I saw the associated doc was not updated with this capability and how it would be used. Any plan to add this to the doc? Thanks. |
|
can you contribute the documentation ? that would help us
…On Fri, Mar 3, 2023 at 6:40 PM Adrian Dozsa ***@***.***> wrote:
This is a helpful capability. Thank you for this enhancement. I saw the
associated doc was not updated with this capability and how it would be
used. Any plan to add this to the doc? Thanks.
—
Reply to this email directly, view it on GitHub
<#1231 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCWQ4PET5MOOPPOGOYDW2IUHRANCNFSM6AAAAAAQIENKTY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
I'll see if I can find some time to look at this in the coming days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Proposed solution to #1214 and #646
This could probably be improved a great deal, but I've reached a stage with this one where I'd need some more eyes on it.
I'm also struggling with running a lot of the tests, so I am somewhat in the dark on whether or not this has broken anything.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines