-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligning Logo Usage #67
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for thingweb-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The preview gets the wrong color scheme preference from my browser. At the same time, given that we do not have a dark scheme for the website, should we only use the light scheme? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if I would remove logo.png and replace it with some https://raw.githubusercontent.com link to another repository...
Moreover, since I don't think we have dark mode we don't need that complexity unless we come up with a dark-mode style
Do you have the concern due to performance issues? I would be fine to not remove it since it's a one off case. However it still makes sense since the browser can cache it anyways amd might be even faster (someone who uses GitHub visit the webpage for the first time) |
The concern I have is that it is a "website" which gets rendered in the end and I would tend to say the images should be in the same repo. Pointing to other repos etc makes the whole thing rather fragile but maybe it is just me that feels like this.. |
Call on 26.01:
|
This PR: