Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #66: Run dotnet restore before starting LS #101

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

LucasBullen
Copy link

Re-add previously removed workaround for
OmniSharp/omnisharp-node-client#265

Signed-off-by: Lucas Bullen [email protected]

@mickaelistria
Copy link
Contributor

I'm wondering whether it wouldn't be better to wait for OmniSharp to include the LSP support out of the box rather than stacking workarounds for the deprecated nodejs wrapper. What do you think?

Re-add previously removed workaround for
OmniSharp/omnisharp-node-client#265

Signed-off-by: Lucas Bullen <[email protected]>
@LucasBullen
Copy link
Author

I think it is important to have this workaround in for now, until we have the support, as users are not aware of the required dotnet restore and it would be better to do it on our end instead of enforcing a behaviour that will become unnecessary after the OmniSharp update.

@mickaelistria
Copy link
Contributor

Ok, feel free to push to master then.

@LucasBullen LucasBullen merged commit 0ec977a into eclipse-acute:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants