Editor doesn't support projects using .csproj (project.json required) #51
Comments
|
@LucasBullen at the moment, I don't think we need to fix it right away as we don't have the needs nor the resource to follow bleeding edge development of dotnet-core. We'll get back to it when dotnet-core 2.0 is released. |
|
OmniSharp-node-client 7.0.7 can run with dotnet 2.0 but still isn't able to process .NET project using a .csproj file. |
|
OmniSharp/omnisharp-node-client#438 it should help for dotnet 2. I tested it with projects generated with help dotnet 2. |
|
@AndrienkoAleksandr Thanks for the hint! I just tried it and it seems like the "initialize" request never returns and drives the client to timeout. Is this an issue you're aware of? |
|
Hi, @mickaelistria . Do you have such problem fot dotnet 1.0.4 or 2.0 preview too? I used this with installed mono 5.2 beta http://www.mono-project.com/download/beta/. And second question Did you find some regression? Did it work earlier? |
|
We have to be compliant with an older mono (4.8.0, the one shipped with
Fedora 26.
Using tag v7.0.7 from omnisharp-node-client worked fine.
|
mickaelistria
changed the title
mickaelistria
changed the title
|
Hmm... I will see on it today. |
Signed-off-by: Mickael Istria <[email protected]>
|
Hi @mickaelistria, I found that "--assembly-loader=strict" correct working only from 5.2 beta http://www.mono-project.com/docs/about-mono/releases/5.2.0/#strong-assembly-names and .csproj based projects working correct with this version. So I'am working on pull request where we check mono version and if it's 5.2 or higher we activate "--assembly-loader=strict", it should fix current breaking changes with mono 4.8 (I'm sorry for this breaking changes). It's sad but mono 4.8 can't working with this params... I asked guys from omnisharp-roslyn, they said in the some future release will be released binary with embedded mono... |
|
I'm sorry for this breaking changes
Don't be! We're still in incubation mode for aCute, and we can test the
changes before we merge them, so even such bug upstream don't impact us
that hard.
On the contrary, it's very cool to see you working that well on the
Language Server, that helps a lot!
It's sad but mono 4.8 can't working with this params... I asked guys from
omnisharp-roslyn, they said in the some future release will be released
binary with embedded mono..
Right, however the tricky part is to know when ;)
I've got a question for you: if I use mono 4.8 (which is the case on
Fedora), should the language server work for projects with a `.csproj` file
or is it something that's not supported by mono 4.x ?
|
|
can you check please ? |
Signed-off-by: Mickael Istria <[email protected]>
Better support for dotnet-core 2.0 projects, embeds its own version of mono Signed-off-by: Mickael Istria <[email protected]>
Better support for dotnet-core 2.0 projects, embeds its own version of mono Signed-off-by: Mickael Istria <[email protected]>
Better support for dotnet-core 2.0 projects, embeds its own version of mono Signed-off-by: Mickael Istria <[email protected]>
|
Fixed with mickaelistria@05eac6f |
Currently, the editor, as it relies on Omnisharp-node-client suffering from OmniSharp/omnisharp-node-client#434 , is not able to provide edition assistance for dotnet 2.0 project (using
.csprojdescription files).The text was updated successfully, but these errors were encountered: