Server doesn't work with mono 4.8 #439

mickaelistria · 2017-07-31T10:11:58Z

A recent change to better support mono 5.2 ( 12cf220 ) seems to break support for mono 4.8.

Most operations either timeout or return empty results when something is expected

Here are some of the 1st few messages received from LS after an initialize request as example

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.Startup\",\"Message\":\"Omnisharp server running using Stdio at location '/home/mistria/runtime-demoLSP/csharp-in-Eclipse3' on host 17522.\"},\"Seq\":1,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.DotNet.DotNetProjectSystem\",\"Message\":\"Initializing in /home/mistria/runtime-demoLSP/csharp-in-Eclipse3\"},\"Seq\":2,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.DotNet.DotNetProjectSystem\",\"Message\":\"Auto package restore: True\"},\"Seq\":3,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.DotNet.DotNetProjectSystem\",\"Message\":\"Update workspace context\"},\"Seq\":4,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.DotNet.DotNetProjectSystem\",\"Message\":\"Resolving projects references\"},\"Seq\":5,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.MSBuild.MSBuildProjectSystem\",\"Message\":\"MSBUILD_EXE_PATH environment variable set to /home/mistria/git/aCute/org.eclipse.acute.omnisharpServer/server/omnisharp-node-client-7.0.7/omnisharp-mono/msbuild/MSBuild.dll\"},\"Seq\":6,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.MSBuild.MSBuildProjectSystem\",\"Message\":\"MSBuildExtensionsPath environment variable set to /home/mistria/git/aCute/org.eclipse.acute.omnisharpServer/server/omnisharp-node-client-7.0.7/omnisharp-mono/msbuild\"},\"Seq\":7,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.MSBuild.MSBuildProjectSystem\",\"Message\":\"MSBuild will use local OmniSharp installation.\"},\"Seq\":8,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.MSBuild.MSBuildProjectSystem\",\"Message\":\"No solution files found in '/home/mistria/runtime-demoLSP/csharp-in-Eclipse3'\"},\"Seq\":9,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.MSBuild.MSBuildProjectSystem\",\"Message\":\"Loading project: /home/mistria/runtime-demoLSP/csharp-in-Eclipse3/csharp-in-Eclipse3.csproj\"},\"Seq\":10,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Type\":\"unknown\",\"Event\":\"unknown\",\"Seq\":-1,\"Body\":{\"Message\":\"Discovered Mono file path: /usr/bin/mono\"}}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Type\":\"unknown\",\"Event\":\"unknown\",\"Seq\":-1,\"Body\":{\"Message\":\"Resolved symbolic link for Mono file path: /usr/bin/mono-sgen\"}}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"ERROR\",\"Name\":\"OmniSharp.MSBuild.ProjectFile.ProjectFileInfo\",\"Message\":\"The \\\"Microsoft.NET.Build.Tasks.ReportAssetsLogMessages\\\" task could not be loaded from the assembly /usr/lib64/dotnet/sdk/2.0.0-preview2-006497/Sdks/Microsoft.NET.Sdk/build/../tools/net46/Microsoft.NET.Build.Tasks.dll. Could not load file or assembly '/usr/lib64/dotnet/sdk/2.0.0-preview2-006497/Sdks/Microsoft.NET.Sdk/build/../tools/net46/Microsoft.NET.Build.Tasks.dll' or one of its dependencies Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.\"},\"Seq\":11,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"WARNING\",\"Name\":\"OmniSharp.MSBuild.MSBuildProjectSystem\",\"Message\":\"Failed to load project file '/home/mistria/runtime-demoLSP/csharp-in-Eclipse3/csharp-in-Eclipse3.csproj'.\"},\"Seq\":12,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"MsBuildProjectDiagnostics\",\"Body\":{\"FileName\":\"/home/mistria/runtime-demoLSP/csharp-in-Eclipse3/csharp-in-Eclipse3.csproj\",\"Warnings\":[],\"Errors\":[{\"LogLevel\":\"Error\",\"FileName\":\"/usr/lib64/dotnet/sdk/2.0.0-preview2-006497/Sdks/Microsoft.NET.Sdk/build/Microsoft.PackageDependencyResolution.targets\",\"Text\":\"The \\\"Microsoft.NET.Build.Tasks.ReportAssetsLogMessages\\\" task could not be loaded from the assembly /usr/lib64/dotnet/sdk/2.0.0-preview2-006497/Sdks/Microsoft.NET.Sdk/build/../tools/net46/Microsoft.NET.Build.Tasks.dll. Could not load file or assembly '/usr/lib64/dotnet/sdk/2.0.0-preview2-006497/Sdks/Microsoft.NET.Sdk/build/../tools/net46/Microsoft.NET.Build.Tasks.dll' or one of its dependencies Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.\",\"StartLine\":322,\"StartColumn\":5,\"EndLine\":0,\"EndColumn\":0}]},\"Seq\":13,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.Script.ScriptProjectSystem\",\"Message\":\"Detecting CSX files in '/home/mistria/runtime-demoLSP/csharp-in-Eclipse3'.\"},\"Seq\":14,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.Script.ScriptProjectSystem\",\"Message\":\"Could not find any CSX files\"},\"Seq\":15,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.Services.WorkspaceHelper\",\"Message\":\"Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpWorkspaceOptionsProvider\"},\"Seq\":16,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"log\",\"Body\":{\"LogLevel\":\"INFORMATION\",\"Name\":\"OmniSharp.Startup\",\"Message\":\"Configuration finished.\"},\"Seq\":17,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"Event\":\"started\",\"Body\":null,\"Seq\":18,\"Type\":\"event\"}"}}
{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{\"clientId\":\"client1\",\"command\":\"/diagnostics\",\"request\":{},\"silent\":false,\"sequence\":\"__request2\",\"time\":\"2017-07-31T10:06:52.346Z\"}"}}
{"jsonrpc":"2.0","id":"1","result":{"capabilities":{"textDocumentSync":2,"completionProvider":{},"codeLensProvider":{"resolveProvider":true},"definitionProvider":true,"documentFormattingProvider":true,"documentOnTypeFormattingProvider":{"firstTriggerCharacter":"}","moreTriggerCharacter":[";"]},"documentHighlightProvider":true,"documentRangeFormattingProvider":true,"hoverProvider":true,"referencesProvider":true,"renameProvider":true,"signatureHelpProvider":{"triggerCharacters":["("]},"workspaceSymbolProvider":true,"extended":{"getCodeActionsProvider":true,"runCodeActionProvider":true,"implementationProvider":true,"navigateProvider":true,"highlightProvider":true}}}}

My setup:

$ mono --version
Mono JIT compiler version 4.8.0 (Stable 4.8.0.520/8f6d0f6 Wed Mar 15 15:23:40 UTC 2017)

$ dotnet --version
2.0.0-preview2-006497

The text was updated successfully, but these errors were encountered:

mickaelistria · 2017-07-31T10:12:49Z

cc @AndrienkoAleksandr : this is the issue I've told you about, with more details. Feel free to ask for more if it can help. I'll try with mono 5.2 soon and report whether this fix the issue.

mickaelistria · 2017-07-31T11:12:24Z

I just tried again with the LS from master (which includes 12cf220 ).

$ mono --version
Mono JIT compiler version 5.2.0.213 (tarball Wed Jul 26 18:27:56 UTC 2017)

$ dotnet --version
2.0.0-preview2-006497

The LS is working fine for projects which have a project.json file and returns empty results for projects with a .csproj file. So it's working well with mono 5.2, but doesn't fix https://github.com/mickaelistria/aCute/issues/51

AndrienkoAleksandr · 2017-07-31T14:08:55Z

@mickaelistria Did you generate project with help dotnet 2.0? Because for me this commit activated inside Eclipse CHE correct autocomplete, hover, for dotnet projects generated with help dotnet 2.0 (I don't use project generated with help 1.0.4).

mickaelistria · 2017-07-31T14:24:51Z

Project is generated with dotnet new command.

DustinCampbell · 2017-08-02T12:47:46Z

Unfortunately, in order to support .NET Core 2.0, OmniSharp needs to take advantage of the new "--assembly-loader" flag in Mono 5.2. This is, due to internal API changes in the latest .NET Core 2.0 SDK. There are several issues with details. Here's one where the problem is discussed at length: dotnet/vscode-csharp#1495

mickaelistria · 2017-08-02T13:04:53Z

Thanks @DustinCampbell . Is there an easy way to check for mono version (maybe you're already aware of some dependency that can do it) and to decide whether to set the flag according to it?
I have the impression having the flag makes previous versions of mono entirely fail at booting Omnisharp, so it would be nice to keep those older versions of mono remain at least able to do the work they used to do with omnisharp-node-client.

DustinCampbell · 2017-08-02T13:15:17Z

In Node? I'd probably just regex out the version number from mono --version and then use the semver package.

Note that without the flag, using the latest .NET Core 2.0 SDK will still fail on old versions of Mono.

mickaelistria · 2017-08-02T13:21:55Z

Note that without the flag, using the latest .NET Core 2.0 SDK will still fail on old versions of Mono.

Right. However we can imagine the users who have an old version of mono may remain on this older versions, whereas people doing .NET Core 2.0 are more likely to have the new version. So shipping a language server that's compatible with .NET Core 1.0 at least, and optionally compatible with .NET Core 2.0 if user has a .NET Core 2.0-compatible mono seems like a decent trade-off.

DustinCampbell · 2017-08-02T13:25:19Z

Makes sense. One thing to keep in mind is that it isn't about building .NET Core 2.0 apps. The issue is with using the .NET Core 2.0 SDK, which can still be used to build .NET Core 1.1 apps.

mickaelistria · 2017-08-08T12:23:54Z

#441 helps as it removes the dependency on mono and then make the setup more portable.
However, I now get the following error notification from server:

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{"Event":"log","Body":{"LogLevel":"ERROR","Name":"OmniSharp.MSBuild.ProjectFile.ProjectFileInfo","Message":"The \"Microsoft.NET.Build.Tasks.ReportAssetsLogMessages\" task could not be loaded from the assembly /usr/lib64/dotnet/sdk/2.0.0-preview2-006497/Sdks/Microsoft.NET.Sdk/build/../tools/net46/Microsoft.NET.Build.Tasks.dll. Confirm that the declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask."},"Seq":9,"Type":"event"}"}}

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{"Event":"log","Body":{"LogLevel":"WARNING","Name":"OmniSharp.MSBuild.MSBuildProjectSystem","Message":"Failed to load project file '/home/mistria/runtime-EclipseApplication/someProjecg/someProjecg.csproj'."},"Seq":10,"Type":"event"}"}

I confirm it's using the omnisharp-linux-x64 server with the embedded mono.

As I'm not a .NET expert, I'm failing at interpreting that message.
Does anyone know what this could mean? cc @david-driscoll

DustinCampbell · 2017-08-08T12:51:54Z

You might try updating the .NET Core 2.0 SDK. 2.0.0-preview2-006497 is pretty old and there were definitely some issues with MSBuild task dependencies in the past. You should be able to get the latest here: https://dotnetcli.blob.core.windows.net/dotnet/Sdk/release/2.0.0/dotnet-sdk-latest-linux-x64.tar.gz.

DustinCampbell · 2017-08-08T12:53:01Z

Note: I listed the tarball because, IIRC, you're on Fedora 26.

mickaelistria · 2017-08-08T13:03:37Z

@DustinCampbell thanks.
@omajid Do you know if more recent rpms of dotnet-core 2.0 are available for Fedora 26 ?

DustinCampbell · 2017-08-08T13:18:04Z

The latest RPM for RHEL is here: https://github.com/dotnet/cli/tree/release/2.0.0.

mickaelistria · 2017-08-08T13:21:45Z

On Tue, Aug 8, 2017 at 3:18 PM, Dustin Campbell ***@***.***> wrote: The latest RPM for RHEL is here: https://github.com/dotnet/cli/ tree/release/2.0.0

Thanks, but IIRC, those are not compatible with recent Fedora because of issue with icu: https://github.com/dotnet/cli/issues/4865 (and some other ones)

omajid · 2017-08-08T13:50:02Z

@omajid Do you know if more recent rpms of dotnet-core 2.0 are available for Fedora 26 ?

Preview 2 should be here: https://copr.fedorainfracloud.org/coprs/g/dotnet-sig/dotnet/. We dont have anything newer (yet).

DustinCampbell · 2017-08-08T13:55:41Z

@mickaelistria: If you could try the tarball to verify whether that solves the issue or not would be helpful.

mickaelistria · 2017-08-08T14:16:17Z

Thanks guys. I'll try the tarball promptly (today or tomorrow) and report back whether it works. If you didn't hear from me by then, feel free to ping me.

mickaelistria · 2017-08-08T23:26:27Z

So the server works for project using a project.json but I still see the same issue for project with *.csproj and dotnet 2.0.1-servicing-006924 from the zip you linked.
How does OmniSharp detect the dotnet executable and framework? Is only having dotnet in PATH enough?

mickaelistria · 2017-08-08T23:32:02Z

Actually, the error is different now

{"jsonrpc":"2.0","method":"window/logMessage","params":{"type":3,"message":"{"Event":"log","Body":{"LogLevel":"ERROR","Name":"OmniSharp.MSBuild.ProjectFile.ProjectFileInfo","Message":"The specified task executable location \"/csc.exe\" is invalid."},"Seq":9,"Type":"event"}"}}

I guess I didn't install .NET Core properly so some binaries can't be resolved.

DustinCampbell · 2017-08-08T23:33:48Z

awesome! That's what I was hoping for. 😄

This is a regression that I noticed earlier today. I've already merged a fix and produced a new 1.23.1 release of omnisharp-roslyn. I'm guessing omnisharp-node-client needs updated @david-driscoll?

mickaelistria · 2017-08-09T13:02:43Z

Hurray! I tried the latest release v7.1.2 which uses omnisharp-roslyn 1.23.1 and it worked well on Fedora 26 with a version recent of dotnet-core 2.0 and no dependency on mono!
I believe it's a pretty satisfying result from integrator and user POV, so I'm closing this issue.
Thanks for your assistance!

DustinCampbell · 2017-08-09T13:05:32Z

Great!

AndrienkoAleksandr mentioned this issue Aug 2, 2017

Fix fail start when mono binary version lower than 5.2 #440

Closed

mickaelistria closed this as completed Aug 9, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server doesn't work with mono 4.8 #439

Server doesn't work with mono 4.8 #439

mickaelistria commented Jul 31, 2017

mickaelistria commented Jul 31, 2017

mickaelistria commented Jul 31, 2017

AndrienkoAleksandr commented Jul 31, 2017 •

edited

Loading

mickaelistria commented Jul 31, 2017

DustinCampbell commented Aug 2, 2017

mickaelistria commented Aug 2, 2017

DustinCampbell commented Aug 2, 2017

mickaelistria commented Aug 2, 2017 via email

DustinCampbell commented Aug 2, 2017

mickaelistria commented Aug 8, 2017 •

edited

Loading

DustinCampbell commented Aug 8, 2017

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 8, 2017 •

edited

Loading

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 8, 2017 via email

omajid commented Aug 8, 2017

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 8, 2017 via email

mickaelistria commented Aug 8, 2017

mickaelistria commented Aug 8, 2017

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 9, 2017

DustinCampbell commented Aug 9, 2017

Server doesn't work with mono 4.8 #439

Server doesn't work with mono 4.8 #439

Comments

mickaelistria commented Jul 31, 2017

mickaelistria commented Jul 31, 2017

mickaelistria commented Jul 31, 2017

AndrienkoAleksandr commented Jul 31, 2017 • edited Loading

mickaelistria commented Jul 31, 2017

DustinCampbell commented Aug 2, 2017

mickaelistria commented Aug 2, 2017

DustinCampbell commented Aug 2, 2017

mickaelistria commented Aug 2, 2017 via email

DustinCampbell commented Aug 2, 2017

mickaelistria commented Aug 8, 2017 • edited Loading

DustinCampbell commented Aug 8, 2017

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 8, 2017 • edited Loading

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 8, 2017 via email

omajid commented Aug 8, 2017

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 8, 2017 via email

mickaelistria commented Aug 8, 2017

mickaelistria commented Aug 8, 2017

DustinCampbell commented Aug 8, 2017

mickaelistria commented Aug 9, 2017

DustinCampbell commented Aug 9, 2017

AndrienkoAleksandr commented Jul 31, 2017 •

edited

Loading

mickaelistria commented Aug 8, 2017 •

edited

Loading

mickaelistria commented Aug 8, 2017 •

edited

Loading