couple of additions #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous solution of delaying before calling update is inconsistent - with larger files or on specific filesystems, the file may not be released before the delay expires (I could reproduce this using WSL2).
There's no 'one size fits all' solution down this path, and adding a customisation option for the delay seems messy. Instead, I've added completion events for change/delete which avoid this issue.
I also added support for multiple associations per key - clang and gcc currently have different output formats when using -save-temps (one generates .ext.s, the other .s which required changes to the associations settings when switching between compilers.
Having an array of associations solves this problem, while also giving additional flexibility for those that want to take advantage of it. An alternative would be to support regular expressions or some other form of 'complex' matching