-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset MouseIsOver when the control loses focus #12598
Open
LeafShi1
wants to merge
4
commits into
dotnet:main
Choose a base branch
from
LeafShi1:Fix_12590_ComboBoxDropdownButtonnDisappear
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reset MouseIsOver when the control loses focus #12598
LeafShi1
wants to merge
4
commits into
dotnet:main
from
LeafShi1:Fix_12590_ComboBoxDropdownButtonnDisappear
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12598 +/- ##
===================================================
+ Coverage 75.73242% 76.01419% +0.28176%
===================================================
Files 3153 3175 +22
Lines 635807 638857 +3050
Branches 46975 47178 +203
===================================================
+ Hits 481512 485622 +4110
+ Misses 150870 149737 -1133
- Partials 3425 3498 +73
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
changed the title
Fix 12590 combo box dropdown buttonn disappear
Fix 12590 combo box dropdown button disappear
Dec 6, 2024
LeafShi1
changed the title
Fix 12590 combo box dropdown button disappear
Reset MouseIsOver when the control loses focus
Dec 6, 2024
LeafShi1
added
the
waiting-review
This item is waiting on review by one or more members of team
label
Dec 6, 2024
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ComboBox/ComboBox.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
📭 waiting-author-feedback
The team requires more information from the author
and removed
waiting-review
This item is waiting on review by one or more members of team
labels
Dec 8, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 9, 2024
Tanya-Solyanik
added
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 9, 2024
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
The team requires more information from the author
label
Dec 11, 2024
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/ComboBoxTests.cs
Show resolved
Hide resolved
LeafShi1
commented
Dec 12, 2024
src/System.Windows.Forms/src/System/Windows/Forms/Controls/ComboBox/ComboBox.cs
Show resolved
Hide resolved
LeafShi1
added
the
waiting-review
This item is waiting on review by one or more members of team
label
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12590
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
When change the RightToLeft property after expanding the Popup FlatStyle comboBox, the dropdown button on the comboBox disappeared
After
The dropdown button on the comboBox can be show normally
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow