Merge pull request #60 from tmat/IVT

Make PdbWriter internal
dotnet · May 17, 2017 · fe84806 · fe84806
2 parents 115442d + 1d7a06e
commit fe84806
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/Microsoft.DiaSymReader.Converter/InternalsVisibleTo.cs b/src/Microsoft.DiaSymReader.Converter/InternalsVisibleTo.cs
@@ -0,0 +1,4 @@
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("Microsoft.Cci, PublicKey=002400000480000094000000060200000024000052534131000400000100010007D1FA57C4AED9F0A32E84AA0FAEFD0DE9E8FD6AEC8F87FB03766C834C99921EB23BE79AD9D5DCC1DD9AD236132102900B723CF980957FC4E177108FC607774F29E8320E92EA05ECE4E821C0A5EFE8F1645C4C0C93C1AB99285D622CAA652C1DFAD63D745D6F2DE5F17E5EAF0FC4963D261C8A12436518206DC093344D5AD293")]
+
diff --git a/src/Microsoft.DiaSymReader.Converter/PdbConverter.cs b/src/Microsoft.DiaSymReader.Converter/PdbConverter.cs
@@ -178,7 +178,7 @@ public void ConvertWindowsToPortable(PEReader peReader, Stream sourcePdbStream,
         /// <exception cref="BadImageFormatException">The format of the PE image or the source PDB image is invalid.</exception>
         /// <exception cref="InvalidDataException">The PDB doesn't match the CodeView Debug Directory record in the PE image.</exception>
         /// <exception cref="IOException">IO error while reading from or writing to a stream.</exception>
-        public void ConvertPortableToWindows<TDocumentWriter>(PEReader peReader, MetadataReader pdbReader, PdbWriter<TDocumentWriter> pdbWriter, PdbConversionOptions options)
+        internal void ConvertPortableToWindows<TDocumentWriter>(PEReader peReader, MetadataReader pdbReader, PdbWriter<TDocumentWriter> pdbWriter, PdbConversionOptions options)
         {
             new PdbConverterPortableToWindows<TDocumentWriter>(_diagnosticReporterOpt).Convert(
                 peReader ?? throw new ArgumentNullException(nameof(peReader)), 

diff --git a/src/Microsoft.DiaSymReader.Converter/SymReader/PdbWriter.cs b/src/Microsoft.DiaSymReader.Converter/SymReader/PdbWriter.cs
@@ -5,7 +5,7 @@
 
 namespace Microsoft.DiaSymReader
 {
-    public abstract class PdbWriter<TDocumentWriter>
+    internal abstract class PdbWriter<TDocumentWriter>
     {
         public abstract TDocumentWriter DefineDocument(string name, Guid language, Guid vendor, Guid type, Guid algorithmId, byte[] checksum);
         public abstract void DefineSequencePoints(TDocumentWriter document, int count, int[] offsets, int[] startLines, int[] startColumns, int[] endLines, int[] endColumns);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		using System.Runtime.CompilerServices;

		[assembly: InternalsVisibleTo("Microsoft.Cci, PublicKey=002400000480000094000000060200000024000052534131000400000100010007D1FA57C4AED9F0A32E84AA0FAEFD0DE9E8FD6AEC8F87FB03766C834C99921EB23BE79AD9D5DCC1DD9AD236132102900B723CF980957FC4E177108FC607774F29E8320E92EA05ECE4E821C0A5EFE8F1645C4C0C93C1AB99285D622CAA652C1DFAD63D745D6F2DE5F17E5EAF0FC4963D261C8A12436518206DC093344D5AD293")]