Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd #106603

Closed
v-wenyuxu opened this issue Aug 19, 2024 · 4 comments · Fixed by #106968
Closed

Test failure: JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd #106603

v-wenyuxu opened this issue Aug 19, 2024 · 4 comments · Fixed by #106968
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs GCStress in-pr There is an active PR which will close this issue when it is merged os-linux Linux OS (any supported distro)
Milestone

Comments

@v-wenyuxu
Copy link

Failed in: runtime-coreclr gcstress0x3-gcstress0xc 20240818.1

Failed tests:

coreclr linux arm Checked gcstress0x3 @ (Debian.12.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-arm32v7
    - JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd
coreclr linux arm64 Checked gcstress0x3 @ (Ubuntu.2004.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-20.04-helix-arm64v8
    - JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd

Error message:

 
cmdLine:/root/helix/work/workitem/e/JIT/Directed/Directed_3/../tailcall/mutual_recursion/mutual_recursion.sh Timed Out (timeout in milliseconds: 3600000 from variable __TestTimeout, start: 8/18/2024 3:15:56 PM, end: 8/18/2024 4:15:56 PM)

Return code:      -100
Raw output file:      /root/helix/work/workitem/uploads/tailcall/mutual_recursion/output.txt
Raw output:
BEGIN EXECUTION
/root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true mutual_recursion.dll ''
[FirstMethod] - 158.499500ms
[SecondMethod] - 22.000000ms
[ThirdMethod] - 29540.908900ms
[FourthMethod] - 193.637200ms
[FifthMethod] - 2980864.325900ms

cmdLine:/root/helix/work/workitem/e/JIT/Directed/Directed_3/../tailcall/mutual_recursion/mutual_recursion.sh Timed Out (timeout in milliseconds: 3600000 from variable __TestTimeout, start: 8/18/2024 3:15:56 PM, end: 8/18/2024 4:15:56 PM)
Printing stacktrace from '/home/helixbot/dotnetbuild/dumps/crashdump_260.dmp.crashreport.json'
Test Harness Exitcode is : -100
To run the test:
Set up CORE_ROOT and run.
> /root/helix/work/workitem/e/JIT/Directed/Directed_3/../tailcall/mutual_recursion/mutual_recursion.sh

Stack trace:

   at Xunit.Assert.True(Nullable`1 condition, String userMessage) in /_/src/Microsoft.DotNet.XUnitAssert/src/BooleanAsserts.cs:line 146
   at TestLibrary.OutOfProcessTest.RunOutOfProcessTest(String assemblyPath, String testPathPrefix)
   at Program.<<Main>$>g__TestExecutor241|0_242(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)
@v-wenyuxu v-wenyuxu added arch-arm32 os-linux Linux OS (any supported distro) GCStress blocking-clean-ci-optional Blocking optional rolling runs labels Aug 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 19, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 19, 2024
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 19, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Aug 19, 2024
@v-wenyuxu
Copy link
Author

Failed in: runtime-coreclr gcstress0x3-gcstress0xc 20240825.1

Failed tests:

coreclr linux arm Checked gcstress0x3 @ (Debian.12.Arm32.Open)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-arm32v7
    - JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd
coreclr linux arm64 Checked gcstress0x3 @ (Ubuntu.2004.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:ubuntu-20.04-helix-arm64v8
    - JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd

Error message:

 
cmdLine:/root/helix/work/workitem/e/JIT/Directed/Directed_3/../tailcall/mutual_recursion/mutual_recursion.sh Timed Out (timeout in milliseconds: 3600000 from variable __TestTimeout, start: 8/25/2024 2:51:00 PM, end: 8/25/2024 3:51:00 PM)

Return code:      -100
Raw output file:      /root/helix/work/workitem/uploads/tailcall/mutual_recursion/output.txt
Raw output:
BEGIN EXECUTION
/root/helix/work/correlation/corerun -p System.Reflection.Metadata.MetadataUpdater.IsSupported=false -p System.Runtime.Serialization.EnableUnsafeBinaryFormatterSerialization=true mutual_recursion.dll ''
[FirstMethod] - 161.387500ms
[SecondMethod] - 21.829100ms
[ThirdMethod] - 29195.583800ms
[FourthMethod] - 197.980600ms
[FifthMethod] - 3114073.315400ms

cmdLine:/root/helix/work/workitem/e/JIT/Directed/Directed_3/../tailcall/mutual_recursion/mutual_recursion.sh Timed Out (timeout in milliseconds: 3600000 from variable __TestTimeout, start: 8/25/2024 2:51:00 PM, end: 8/25/2024 3:51:00 PM)
Printing stacktrace from '/home/helixbot/dotnetbuild/dumps/crashdump_259.dmp.crashreport.json'
Test Harness Exitcode is : -100
To run the test:
Set up CORE_ROOT and run.
> /root/helix/work/workitem/e/JIT/Directed/Directed_3/../tailcall/mutual_recursion/mutual_recursion.sh

Stack trace:

   at Xunit.Assert.True(Nullable`1 condition, String userMessage) in /_/src/Microsoft.DotNet.XUnitAssert/src/BooleanAsserts.cs:line 146
   at TestLibrary.OutOfProcessTest.RunOutOfProcessTest(String assemblyPath, String testPathPrefix)
   at Program.<<Main>$>g__TestExecutor241|0_242(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass0_0&)

@jakobbotsch
Copy link
Member

I was able to bisect this to the range 7963a49..f9c0846. In that range we picked up the preview 7 SDK, which seems like it also included a new fsc version. I see significant IL codegen differences that I think are leading to the differences. Even without GC stress the preview7 version is much, much slower than the previous version. Will try to distill the problem a bit and open an issue on the F# repo.

@jakobbotsch
Copy link
Member

I opened dotnet/fsharp#17607 about the degraded IL codegen. I'm going to fix this in the repo by making the test GC stress incompatible.

@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Aug 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci-optional Blocking optional rolling runs GCStress in-pr There is an active PR which will close this issue when it is merged os-linux Linux OS (any supported distro)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants